Page MenuHomePhabricator

OOUI: Stylelint failing
Closed, ResolvedPublic

Description

On a fresh clone of OOUI, running npm install and then npm test fails. Stylelint fails with the following message - TypeError: Cannot read property 'addQmark' of undefined.

1~/wmf
2▶ git clone ssh://prtksxna@gerrit.wikimedia.org:29418/oojs/ui test-ooui
3Cloning into 'test-ooui'...
4remote: Counting objects: 2593, done
5remote: Finding sources: 100% (35/35)
6remote: Getting sizes: 100% (23/23)
7remote: Compressing objects: 100% (73148/73148)
8remote: Total 39675 (delta 10), reused 39661 (delta 4)
9Receiving objects: 100% (39675/39675), 5.72 MiB | 304.00 KiB/s, done.
10Resolving deltas: 100% (30870/30870), done.
11
12~/wmf
13▶ cd test-ooui
14
15~/wmf/test-ooui master ✔ 9h23m
16▶ npm install
17npm WARN deprecated gulp-util@3.0.7: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
18npm WARN deprecated gulp-util@3.0.8: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
19npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
20npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
21
22> fsevents@1.2.4 install /Users/psaxena/wmf/test-ooui/node_modules/fsevents
23> node install
24
25[fsevents] Success: "/Users/psaxena/wmf/test-ooui/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed
26Pass --update-binary to reinstall or --build-from-source to recompile
27
28> phantomjs-prebuilt@2.1.7 install /Users/psaxena/wmf/test-ooui/node_modules/phantomjs-prebuilt
29> node install.js
30
31PhantomJS not found on PATH
32Download already available at /var/folders/fz/v_2wvw310s7_smcbfl39_q9c0000gp/T/phantomjs/phantomjs-2.1.1-macosx.zip
33Verified checksum of previously downloaded file
34Extracting zip contents
35Removing /Users/psaxena/wmf/test-ooui/node_modules/phantomjs-prebuilt/lib/phantom
36Copying extracted folder /var/folders/fz/v_2wvw310s7_smcbfl39_q9c0000gp/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1530075922885/phantomjs-2.1.1-macosx -> /Users/psaxena/wmf/test-ooui/node_modules/phantomjs-prebuilt/lib/phantom
37Writing location.js file
38Done. Phantomjs binary available at /Users/psaxena/wmf/test-ooui/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
39
40> gifsicle@3.0.4 postinstall /Users/psaxena/wmf/test-ooui/node_modules/gifsicle
41> node lib/install.js
42
43 ✔ gifsicle pre-build test passed successfully
44
45> jpegtran-bin@3.2.0 postinstall /Users/psaxena/wmf/test-ooui/node_modules/jpegtran-bin
46> node lib/install.js
47
48 ✔ jpegtran pre-build test passed successfully
49
50> optipng-bin@3.1.4 postinstall /Users/psaxena/wmf/test-ooui/node_modules/optipng-bin
51> node lib/install.js
52
53 ✔ optipng pre-build test passed successfully
54
55> zopflipng-bin@4.1.0 postinstall /Users/psaxena/wmf/test-ooui/node_modules/zopflipng-bin
56> node lib/install.js
57
58 ✔ zopflipng pre-build test passed successfully
59npm notice created a lockfile as package-lock.json. You should commit this file.
60npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is installed. You must install peer dependencies yourself.
61
62added 1333 packages in 73.981s
63
64~/wmf/test-ooui master ✗ 9h24m ◒
65▶ npm test
66
67> oojs-ui@0.27.3 test /Users/psaxena/wmf/test-ooui
68> grunt test
69
70Running "eslint:dev" (eslint) task
71
72Running "stylelint:dev" (stylelint) task
73Warning: Running stylelint failed
74TypeError: Cannot read property 'addQmark' of undefined
75 at Compiler.<anonymous> (/Users/psaxena/wmf/test-ooui/node_modules/nanomatch/lib/compilers.js:92:16)
76 at Compiler.visit (/Users/psaxena/wmf/test-ooui/node_modules/snapdragon/lib/compiler.js:129:15)
77 at Compiler.mapVisit (/Users/psaxena/wmf/test-ooui/node_modules/snapdragon/lib/compiler.js:143:12)
78 at Compiler.compile (/Users/psaxena/wmf/test-ooui/node_modules/snapdragon/lib/compiler.js:168:10)
79 at Snapdragon.compile (/Users/psaxena/wmf/test-ooui/node_modules/snapdragon/index.js:156:32)
80 at /Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:786:23
81 at memoize (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:859:13)
82 at Function.micromatch.compile (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:783:10)
83 at create (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:686:25)
84 at /Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:695:16
85 at memoize (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:859:13)
86 at Function.micromatch.create (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:684:10)
87 at makeRe (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:581:29)
88 at memoize (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:859:13)
89 at Function.micromatch.makeRe (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/node_modules/micromatch/index.js:598:10)
90 at makeRe (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/utils/pattern.js:121:23)
91 at /Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/utils/pattern.js:128:53
92 at Array.map (<anonymous>:null:null)
93 at Object.convertPatternsToRe (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/utils/pattern.js:128:21)
94 at DeepFilter.getFilter (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/providers/filters/entry.js:15:39)
95 at ReaderAsync.Reader.getReaderOptions (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/providers/reader.js:26:38)
96 at ReaderAsync.read (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/providers/reader-async.js:37:28)
97 at Array.map (<anonymous>:null:null)
98 at getWorks (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/index.js:51:18)
99 at async (/Users/psaxena/wmf/test-ooui/node_modules/fast-glob/out/index.js:22:17)
100 at Promise.all.tasks.map.task (/Users/psaxena/wmf/test-ooui/node_modules/stylelint/node_modules/globby/index.js:91:50)
101 at Array.map (<anonymous>:null:null)
102 at getTasks.then.tasks (/Users/psaxena/wmf/test-ooui/node_modules/stylelint/node_modules/globby/index.js:91:38)
103 at <anonymous>:null:null
104 Use --force to continue.
105
106Aborted due to warnings.
107npm ERR! Test failed. See above for more details.

Related Objects