Maniphest T198402

HTMLForm's title field is marked as invalid even if empty
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jun 28 2018, 2:50 PM

Description

While working at a patch for Special:AbuseLog I noticed a tiny bug with the Title field: if you focus it and then click away, a red border appears and the aria-invalid attribute is added. This doesn't prevent form submission, is just an annoying visual bug. Maybe related to T194425 and the patch which caused it? Adding @matmarex just in case.

Details

	Subject	Repo	Branch	Lines +/-
	mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty	mediawiki/core	master	+9 -3

Customize query in gerrit

Related Objects

Mentioned Here: T194425: The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory

Event Timeline

Daimona created this task.Jun 28 2018, 2:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2018, 2:50 PM

I think this was an issue prior to that, it just went unnoticed.

Change 443204 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty

https://gerrit.wikimedia.org/r/443204

gerritbot added a project: Patch-For-Review.Jun 29 2018, 10:55 PM

Change 443204 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty

https://gerrit.wikimedia.org/r/443204

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 3 2018, 2:00 PM

matmarex closed this task as Resolved.Jul 3 2018, 4:55 PM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.