Page MenuHomePhabricator

HTMLForm's title field is marked as invalid even if empty
Closed, ResolvedPublic

Description

While working at a patch for Special:AbuseLog I noticed a tiny bug with the Title field: if you focus it and then click away, a red border appears and the aria-invalid attribute is added. This doesn't prevent form submission, is just an annoying visual bug. Maybe related to T194425 and the patch which caused it? Adding @matmarex just in case.

Event Timeline

Daimona created this task.Jun 28 2018, 2:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2018, 2:50 PM

I think this was an issue prior to that, it just went unnoticed.

Change 443204 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty

https://gerrit.wikimedia.org/r/443204

Change 443204 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty

https://gerrit.wikimedia.org/r/443204

matmarex closed this task as Resolved.Jul 3 2018, 4:55 PM
matmarex claimed this task.
matmarex removed a project: Patch-For-Review.