Maniphest T194425

The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	May 10 2018, 8:08 PM

Description

After today's train I noticed that the "page" field on Special:Abusefilter has become mandatory. This means that users can't test filters the way they want, but instead they have to add a page, which sometimes could make testing unuseful. This bug does not come from AbuseFilter, since on my local wiki using the master I don't have it. Instead, it's more likely to come from either OOUI or HTMLForm. Further investigation coming.

Details

	Subject	Repo	Branch	Lines +/-
	Explicitly declare title fields as optional	mediawiki/extensions/AbuseFilter	wmf/1.32.0-wmf.3	+3 -1
	Explicitly declare title fields as optional	mediawiki/extensions/AbuseFilter	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T198402: HTMLForm's title field is marked as invalid even if empty
T196514: On Special:ChangeContentModel the required field warning is shown before editing form

Event Timeline

Daimona created this task.May 10 2018, 8:08 PM

Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptMay 10 2018, 8:09 PM

Daimona triaged this task as High priority.May 10 2018, 8:09 PM

Woah, the default has been changed in HTMLForm. Glad to know that it was meant to unbreak core widgets, but it broke ours. I'll send a patch shortly, which we should also backport.

This also makes AbuseLog unusable, unless of course you're looking for a specific page.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMay 10 2018, 8:16 PM

Jdforrester-WMF edited projects, added MediaWiki-HTMLForm; removed OOUI.May 10 2018, 8:18 PM

Change 432518 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Explicitly declare title fields as optional

https://gerrit.wikimedia.org/r/432518

gerritbot added a project: Patch-For-Review.May 10 2018, 8:21 PM

Change 432519 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.32.0-wmf.3] Explicitly declare title fields as optional

https://gerrit.wikimedia.org/r/432519

Change 432518 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Explicitly declare title fields as optional

https://gerrit.wikimedia.org/r/432518

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 10 2018, 9:00 PM

Xiplus subscribed.May 11 2018, 2:12 PM

MusikAnimal merged a task: T194611: "Changes made to page" at Special:AbuseFilter/test should not be required.May 13 2018, 10:18 PM

MusikAnimal subscribed.

Do we want to SWAT deploy on Monday? Otherwise we should probably lower this to High priority.

Yes I would like https://gerrit.wikimedia.org/r/#/c/432519/ to be deployed on Monday.

Okee doke! Are either of you familiar with the SWAT process? We need to schedule the change for deployment at https://wikitech.wikimedia.org/wiki/Deployments#Week_of_May_14th, and be on IRC at #wikimedia-operations during that time. You'll probably be asked to check the debug server before the changes are synced. I'm confident enough in that patch to serve as the deployer or responsible developer but I won't be able to do it until the evening SWAT window at 23:00 UTC.

Yes, I'd also like to deploy today. However, I won't be available in any of today's slot. So, feel free to pick it yourself, otherwise I hope to get it for SWAT for tomorrow :-)

The issue is known, it's not caused by AF and is already fixed in the master. It wasn't deployed due to Echo test fails which are blocking patches on past branches. Unfortunately, unless those issues are fixed, we'll have to wait for the next train.

Xaosflux renamed this task from The page field in Special:Abusefilter/test has become mandatory to The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory.May 15 2018, 3:44 PM

Change 432519 abandoned by Huji:
Explicitly declare title fields as optional

Reason:
Can wait for the train

https://gerrit.wikimedia.org/r/432519

Lowering from UBN since we're waiting for the train

Urbanecm merged a task: T195218: Title is mandatory field in Special:AbuseLog.May 20 2018, 5:24 PM

Urbanecm subscribed.

Daimona closed this task as Resolved.May 22 2018, 7:54 PM

Liuxinyu970226 unsubscribed.May 23 2018, 3:49 PM

Daimona mentioned this in T196514: On Special:ChangeContentModel the required field warning is shown before editing form.Jun 6 2018, 9:54 AM

Daimona removed a project: Patch-For-Review.Jun 8 2018, 4:17 PM

Daimona mentioned this in T198402: HTMLForm's title field is marked as invalid even if empty.Jun 28 2018, 2:50 PM

• Vvjjkkii renamed this task from The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory to m6caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Daimona as the assignee of this task.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed AbuseFilter.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: Huji, gerritbot, Aklapper.

Daimona renamed this task from m6caaaaaaa to The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory.Jul 1 2018, 10:18 AM

Daimona closed this task as Resolved.

Daimona claimed this task.