Maniphest T196514

On Special:ChangeContentModel the required field warning is shown before editing form
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jun 5 2018, 8:51 PM

Description

I just noticed this tiny bug on Special:ChangeContentModel: if you simply open the page, a couple of aria- warnings will show up, asking to fill the title field, since it's required. However, this happens before even touching the field and without a submitted request, which I'm sure it's not intentional.
Please note that this was noticed from mobile Safari, although I think it shouldn't be related to the problem itself; also, right now I'm not able to check the code myself, but I'll do it tomorrow, especially looking at recent changes (AFAICR it was working fine a few weeks ago).

Details

	Subject	Repo	Branch	Lines +/-
	SpecialChangeContentModel: Always use POST method for both forms	mediawiki/core	master	+6 -20

Customize query in gerrit

Related Objects

Mentioned Here: T194425: The page field in Special:Abusefilter/test and Special:Abuselog has become mandatory

Event Timeline

Daimona created this task.Jun 5 2018, 8:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2018, 8:51 PM

Well, I found the problem: https://gerrit.wikimedia.org/r/#/c/431632/, with which we already dealt in AbuseFilter in T194425. The reason here is the one expressed in the "ToDo" and in the gerrit comment below. This is the second time that patch is breaking something out of its scope, I'm wondering wether we should revert it and eventually re-apply a nicer version. Adding @matmarex as author.

Ugh, that's unfortunate… I would rather not revert the patch, I think the new way makes much more sense, it's just that we were relying on the old weird behavior in some places :/ I'll submit a fix for Special:ChangeContentModel.

Change 440256 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] SpecialChangeContentModel: Always use POST method for both forms

https://gerrit.wikimedia.org/r/440256

gerritbot added a project: Patch-For-Review.Jun 13 2018, 11:10 PM

For reference, another related fix: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439443

I have just briefly reviewed all other uses of 'type' => 'title' in MediaWiki and extensions and it seems that the other ones should be fine, since the field seems to actually be required in them (or is the only field in the form).

Thanks for checking :-)

• Vvjjkkii renamed this task from On special:changecontentmodel the required field warning is shown before editing form to lkbaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Daimona renamed this task from lkbaaaaaaa to On special:changecontentmodel the required field warning is shown before editing form.Jul 1 2018, 9:41 AM

Daimona raised the priority of this task from High to Needs Triage.

Daimona removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Daimona updated the task description. (Show Details)

Daimona added subscribers: gerritbot, Aklapper.

matmarex merged a task: T238486: Special:ContentModel should not show errors before input..Nov 17 2019, 6:04 AM

matmarex added a subscriber: Soda.

Ammarpad merged a task: T222535: Special:ChangeContentModel shows errors before the form is submitted.Nov 17 2019, 8:22 AM

Ammarpad added subscribers: Munja, DannyS712, JJMC89 and 2 others.

1997kB moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Dec 24 2019, 2:02 PM

1997kB moved this task from Special:Contributions / Special:DeletedContributions to To triage on the MediaWiki-Special-pages board.Dec 24 2019, 2:43 PM

Reedy renamed this task from On special:changecontentmodel the required field warning is shown before editing form to On Special:ChangeContentModel the required field warning is shown before editing form.Apr 22 2020, 2:44 PM

Ammarpad merged a task: T255696: ChangeContentModel should not give a warning when no input is provided.Jun 17 2020, 7:37 PM

Ammarpad added a subscriber: Huji.

Change 440256 merged by jenkins-bot:
[mediawiki/core@master] SpecialChangeContentModel: Always use POST method for both forms

https://gerrit.wikimedia.org/r/440256

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2020, 9:10 PM

Huji closed this task as Resolved.Jun 18 2020, 9:42 PM

Huji assigned this task to matmarex.

Huji triaged this task as Low priority.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 18 2020, 10:00 PM