Maniphest T198501

SpecialWatchlist::cutoffselector() uses localized number string ("0,04" instead of "0.04" in some locales) in calculations
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	edwardspec
	Jun 29 2018, 4:56 PM

Description

In SpecialWatchlist::cutoffselector(), values like 1/24 or 6/24 are cast to string via strval(). However, in some locales (e.g. $wgShellLocale = 'ru_RU.utf8';) strval will return a localized form of the number, e.g. "0,04" instead of "0.04".

Later, when this "0,04" is used in arithmetic operations, it's treated as "0". (and PHP warning "A non well formed numeric value encountered" is shown).

Details

	Subject	Repo	Branch	Lines +/-
	Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist	mediawiki/core	REL1_31	+23 -32
	Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist	mediawiki/core	master	+23 -32

Customize query in gerrit

Related Objects

Mentioned In: T199566: Period of time resets to 1 hour in the watchlist

Event Timeline

edwardspec created this task.Jun 29 2018, 4:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2018, 4:56 PM

edwardspec updated the task description. (Show Details)Jun 29 2018, 4:58 PM

edwardspec updated the task description. (Show Details)

edwardspec updated the task description. (Show Details)Jun 29 2018, 5:01 PM

edwardspec added a project: MediaWiki-General.Jun 29 2018, 5:06 PM

edwardspec edited projects, added MediaWiki-Special-pages, MediaWiki-Internationalization; removed MediaWiki-General.

edwardspec updated the task description. (Show Details)Jun 30 2018, 12:39 AM

Change 443298 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist

https://gerrit.wikimedia.org/r/443298

gerritbot added a project: Patch-For-Review.Jul 1 2018, 2:18 AM

Change 443298 merged by jenkins-bot:
[mediawiki/core@master] Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist

https://gerrit.wikimedia.org/r/443298

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 10 2018, 12:00 AM

Change 444768 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@REL1_31] Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist

https://gerrit.wikimedia.org/r/444768

Change 444768 merged by jenkins-bot:
[mediawiki/core@REL1_31] Avoid arithmetics on localized number string ("0,04") in SpecialWatchlist

https://gerrit.wikimedia.org/r/444768

edwardspec closed this task as Resolved.Jul 18 2018, 11:34 AM

edwardspec removed a project: Patch-For-Review.

matej_suchanek mentioned this in T199566: Period of time resets to 1 hour in the watchlist.Jul 29 2018, 10:04 AM

	F23076098: T198501.png
	Jun 29 2018, 5:00 PM

	F23076097: T198501.png
	Jun 29 2018, 4:59 PM

SpecialWatchlist::cutoffselector() uses localized number string ("0,04" instead of "0.04" in some locales) in calculationsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

SpecialWatchlist::cutoffselector() uses localized number string ("0,04" instead of "0.04" in some locales) in calculations
Closed, ResolvedPublic
Actions