Maniphest T199566

Period of time resets to 1 hour in the watchlist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	GTrang
	Jul 13 2018, 6:33 PM

Description

When viewing the watchlist and then choosing any period of time to display and clicking the "Show" button, the selected period of time is used as expected, but the dropdown box resets to displaying "1 hour". This should not happen, though. Instead, the dropdown box should display what the user had selected before clicking the button.

Details

	Subject	Repo	Branch	Lines +/-
	Treat all time values on Special:Watchlist as floats	mediawiki/core	REL1_31	+2 -2
	Treat all time values on Special:Watchlist as floats	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T164618: Remember "Period of time to display" parameter in watchlist
Mentioned Here: T198501: SpecialWatchlist::cutoffselector() uses localized number string ("0,04" instead of "0.04" in some locales) in calculations
T182471: [minor] RC/Watchlist: a decimal fraction for `Time period to search` instead of 1 hour

Event Timeline

GTrang created this task.Jul 13 2018, 6:33 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 13 2018, 6:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Bencemac subscribed.Jul 14 2018, 6:35 AM

MGChecker subscribed.Jul 16 2018, 6:46 PM

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:32 PM

Note: this concerns the "unimproved" watchlist.

Workaround: set "Days to show in watchlist" on the Watchlist tab in your Preferences to a value that works, such as 5 or a fraction close to the value you want, such as 7.1 (seven point one).

Pipetricker mentioned this in T164618: Remember "Period of time to display" parameter in watchlist.Jul 28 2018, 10:18 AM

Keith_D subscribed.Jul 28 2018, 10:14 PM

Change 449011 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Treat all time values on Special:Watchlist as floats

https://gerrit.wikimedia.org/r/449011

gerritbot added a project: Patch-For-Review.Jul 29 2018, 9:55 AM

matej_suchanek claimed this task.Jul 29 2018, 9:55 AM

Apparently Regression from T198501.

Change 449011 merged by jenkins-bot:
[mediawiki/core@master] Treat all time values on Special:Watchlist as floats

https://gerrit.wikimedia.org/r/449011

matmarex closed this task as Resolved.Jul 30 2018, 12:33 PM

matmarex removed a project: Patch-For-Review.

Change 449170 had a related patch set uploaded (by Bartosz Dziewoński; owner: Matěj Suchánek):
[mediawiki/core@REL1_31] Treat all time values on Special:Watchlist as floats

https://gerrit.wikimedia.org/r/449170

gerritbot added a project: Patch-For-Review.Jul 30 2018, 12:33 PM

Change 449170 merged by jenkins-bot:
[mediawiki/core@REL1_31] Treat all time values on Special:Watchlist as floats

https://gerrit.wikimedia.org/r/449170

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 30 2018, 1:00 PM

Pipetricker unsubscribed.Aug 20 2018, 10:51 PM