Page MenuHomePhabricator

Why does a single-paragraph, plain-old-text change produce a surprisingly messy diff?
Closed, ResolvedPublic

Description

https://de.wikipedia.org/w/index.php?title=Frei.Wild&type=revision&diff=176921179&oldid=176921166&diffmode=source changes a few words in one paragraph and adds a couple of sentences.

Why are the diffs so bad? The wikitext diff doesn't align properly or show that words have been added/removed. The visual diff times out (see T194944), and claims to be adding and removing nearly every paragraph on the entire page (maybe to change the labels on the ref tags?). None of it works as well as it could.

Reported by @Torana in https://www.mediawiki.org/wiki/Topic:Uclt10125tqnvg94

image.png (1×1 px, 1 MB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think this is caused by a) the fact that due to the inserted references the reference indexes of all other refs changed, and b) the timeout that prevents proper diffs inside paragraphs.

E.g. in https://de.wikipedia.org/w/index.php?title=Internationale_Mathematik-Olympiade&diff=149908931&oldid=147676407&diffmode=visual&visualdiff=1 a reference was inserted, too, and all the following references show up as changed (and I still think this isn't the best solution, but I can remember some discussions about that, though I neither know where they occurred or what the outcome was), but in this case no timeout happens and thus the diff is somewhat reasonable.