Page MenuHomePhabricator

non-existing subpage in MediaWiki namespace show empty div with style
Closed, ResolvedPublic

Description

When look at a non-existing subpage in MediaWiki namespace the message [[MediaWiki:Noarticletext]] is not shown, but "<div class="noarticletext"></div>" is add to the HTML. The problem is, that css is declared for that class and so the div has a style. Thats look scary, because there is no text in it.

Please remove that div or show the message on subpages in MediaWiki namespace. Thanks.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/wiki/MediaWiki:Noarticletext/foo

Details

Reference
bz17978

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:32 PM
bzimport set Reference to bz17978.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 7428
fix the empty div

attachment bug17978.patch ignored as obsolete

Cant reproduce. noarticletext is not styled & the message is always shown to me

(In reply to comment #2)

Cant reproduce. noarticletext is not styled & the message is always shown to me

I don't see it in IE8 either. Could you add a screen?

(In reply to comment #4)

I don't see it in IE8 either. Could you add a screen?

Sorry. I see it in monobook skin and also with firefox.

http://translatewiki.net/wiki/MediaWiki:Bug17978?useskin=monobook

I hope, you will see it now. When not, I can add a screenshot at weekend.

It's also in Vector. Look at the HTML source, not at the browser viewport.

(In reply to comment #6)

It's also in Vector. Look at the HTML source, not at the browser viewport.

Yes, but it is not styled and so there is no (visible) problem. So you can fix this, by removing the emtpy div or by removing the stylesheet, or both.

(In reply to comment #7)

(In reply to comment #6)

It's also in Vector. Look at the HTML source, not at the browser viewport.

Yes, but it is not styled and so there is no (visible) problem.

No, that depends. We cannot imply that a div doesn't have styling. Sites, users, extensions and gadgets may apply styling at any time. It applies to Vector just as much as any other skin.

Fix by removing the element where it should not be outputted.

It could be an idea to change the default MediaWiki message to use a different div (e.g. class='mw-defaultmessage' or something), and reserve 'noarticletext' for when there's *really* no text. It doesn't really make sense to show a completely empty page, imho.

(In reply to comment #9)

It could be an idea to change the default MediaWiki message to use a different
div (e.g. class='mw-defaultmessage' or something), and reserve 'noarticletext'
for when there's *really* no text. It doesn't really make sense to show a
completely empty page, imho.

That is possible, but not part of this bug, because here is the problem, that the div is added, when there is nothing to wrap (Go to [[MediaWiki:Not exist]], there is no hint to missing articletext)

Title::getDefaultMessageText returns false and that is than convertet to an emtpy string and outputted. Maybe add a message, if Title::getDefaultMessageText returns false or output 'noarticletext'.

sumanah wrote:

(Removed keywords because patch is obsolete.)

Jdlrobson claimed this task.
Jdlrobson subscribed.

cannot reproduce. Nothing matches the selector .noarticletext on given page.