Page MenuHomePhabricator
Create Task
Maniphest T200004

Octal escape sequence overflow in Preferences test
Closed, ResolvedPublicBUG REPORT
Actions

Description

Environment:

MediaWikimaster 1fb1241
PHP7.2.7

Steps to Reproduce:

$ php tests/phpunit/phpunit.php

Actual Results:

Using PHP 7.2.7
PHP Warning:  Octal escape sequence overflow \666 is greater than \377 in /mediawiki/tests/phpunit/includes/preferences/FiltersTest.php on line 105
PHPUnit 6.5.9 by Sebastian Bergmann and contributors.

.......

Expected Results:
Without PHP Warning before starting test.

Details

SubjectRepoBranchLines +/-
Fix octal escape sequence overflow in FiltersTest.phpmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

RazeSoldier created this task.Jul 19 2018, 12:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2018, 12:53 PM
RazeSoldier added a project: MediaWiki-Core-Tests.Jul 19 2018, 1:12 PM
RazeSoldier moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
gerritbot subscribed.Jul 19 2018, 2:13 PM

Change 446825 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Fix octal escape sequence overflow in FiltersTest.php

https://gerrit.wikimedia.org/r/446825

gerritbot added a project: Patch-For-Review.Jul 19 2018, 2:13 PM
RazeSoldier claimed this task.Jul 19 2018, 2:14 PM
RazeSoldier triaged this task as Medium priority.
Legoktm added a project: PHP 7.2 support.Jul 20 2018, 8:19 PM
gerritbot added a comment.Jul 20 2018, 8:37 PM

Change 446825 merged by jenkins-bot:
[mediawiki/core@master] Fix octal escape sequence overflow in FiltersTest.php

https://gerrit.wikimedia.org/r/446825

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 20 2018, 9:00 PM
RazeSoldier closed this task as Resolved.Jul 20 2018, 9:13 PM
RazeSoldier moved this task from Untriaged to MediaWiki core on the PHP 7.2 support board.
Krinkle awarded a token.Jul 21 2018, 5:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits