Page MenuHomePhabricator
Create Task
Maniphest T200429

rebaser: Connecting to a document tries to repaint every cursor position in history
Closed, ResolvedPublic
Actions

Description

@Catrope: "ve.ce.Surface#onPosition calls setTimeout() to repaint author selections. This takes 15-20ms each, for 4k transactions that's a long time."

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (218cad9c7)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to master (e0f344c72)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: Debounce position eventsVisualEditor/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 26 2018, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2018, 1:38 PM
• marcella subscribed.Jul 26 2018, 1:38 PM
gerritbot subscribed.Jul 26 2018, 1:39 PM

Change 448039 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ce.Surface: Debounce position events

https://gerrit.wikimedia.org/r/448039

gerritbot added a project: Patch-For-Review.Jul 26 2018, 1:39 PM
gerritbot added a comment.Jul 26 2018, 4:03 PM

Change 448039 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: Debounce position events

https://gerrit.wikimedia.org/r/448039

gerritbot added a comment.Jul 26 2018, 6:08 PM

Change 448088 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (218cad9c7)

https://gerrit.wikimedia.org/r/448088

gerritbot added a comment.Jul 28 2018, 11:54 PM

Change 448989 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e0f344c72)

https://gerrit.wikimedia.org/r/448989

Jdforrester-WMF assigned this task to Esanders.Jul 29 2018, 12:16 AM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Jul 29 2018, 12:32 AM

Change 448989 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e0f344c72)

https://gerrit.wikimedia.org/r/448989

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 29 2018, 1:00 AM
gerritbot added a comment.Jul 31 2018, 10:15 PM

Change 448088 abandoned by Bartosz Dziewoński:
Update VE core submodule to master (218cad9c7)

Reason:
Duplicate/subset of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /448989

https://gerrit.wikimedia.org/r/448088

Esanders closed this task as Resolved.Aug 6 2018, 2:05 PM
• Deskana moved this task from QA to Product owner review on the VisualEditor (Current work) board.Aug 28 2018, 5:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits