Maniphest T200662

Unable to cancel (close) dialog after starting search without selecting template
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Jul 30 2018, 6:13 AM

Description

To reproduce:

Open TemplateWizard;
start typing anything in the search field;
click the 'Cancel' button
the dialog doesn't close, and you get the following error in the Javascript console:

jQuery.Deferred exception: dialog.templateForm is undefined mediaWiki.TemplateWizard.Dialog.prototype.getActionProcess/<@[...]/extensions/TemplateWizard/resources/ext.TemplateWizard.Dialog.js?ebde5:161:5

(I introduced this error in f3d5d6a2eff83aceb8f4aaadecd37ebc1910d321.)

Details

	Subject	Repo	Branch	Lines +/-
	Fix bug with closing dialog before selecting any template	mediawiki/extensions/TemplateWizard	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned Here: rETWIf3d5d6a2eff8: Warn when closing template form that contains any values

Event Timeline

Samwilson created this task.Jul 30 2018, 6:13 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 30 2018, 6:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 449112 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/TemplateWizard@master] Fix bug with closing dialog before selecting any template

https://gerrit.wikimedia.org/r/449112

gerritbot added a project: Patch-For-Review.Jul 30 2018, 6:15 AM

This is a tiny thing; moving into the current sprint. Hope that's groovy.

Samwilson moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Jul 30 2018, 6:19 AM

Samwilson updated the task description. (Show Details)Jul 30 2018, 6:22 AM

• Niharika assigned this task to Samwilson.Jul 30 2018, 11:54 PM

Samwilson moved this task from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.Jul 31 2018, 5:46 AM

Mooeypoo moved this task from Needs Review/Feedback to QA on the Community-Tech-Sprint board.Aug 2 2018, 3:35 PM

Change 449112 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Fix bug with closing dialog before selecting any template

https://gerrit.wikimedia.org/r/449112

• Niharika closed this task as Resolved.Aug 14 2018, 7:13 PM

• Niharika triaged this task as Medium priority.

• Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.

Unable to cancel (close) dialog after starting search without selecting templateClosed, ResolvedPublic0.5 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Unable to cancel (close) dialog after starting search without selecting template
Closed, ResolvedPublic0.5 Estimated Story Points
Actions