Maniphest T201598

selenium: ".lemma-widget_edit" still not visible after 10000ms
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Pablo-WMDE
	Aug 9 2018, 9:27 AM

Project Tags

Referenced Files

None

Subscribers

Description

08:48:54 1) Lexeme:Forms can add representation:
08:48:54 element (".lemma-widget_edit") still not visible after 10000ms

e.g. https://integration.wikimedia.org/ci/job/mwext-mw-selenium-node-composer-jessie/1377/console

Appears to be happening for

mwext-mw-selenium-node-composer-jessie
mediawiki-core-qunit-selenium-jessie
mwext-mw-selenium-composer-jessie
quibble-composer-mysql-php70-docker

The header JS seems to be never loaded fully, consequently the page object never indicates the page to be fully loaded which makes many tests broken (during the setup phase)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	newLexemeHeaderStore: specify dependencies	Pablo Grass (WMDE)	mediawiki/extensions/WikibaseLexeme	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWLE0022802ad5de: newLexemeHeaderStore: specify dependencies
rEWLEaf377cb05159: newLexemeHeaderStore: specify dependencies
T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined
Mentioned Here: T201600: Reading of LexemeLanguageCodePropertyId in JS before value is set

Event Timeline

• Pablo-WMDE created this task.Aug 9 2018, 9:27 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration5 board.

• Pablo-WMDE mentioned this in T201337: Quibble & WikibaseLexeme: selenium, TypeError: Cannot read property 'value' of undefined.

• Pablo-WMDE added subscribers: Jakob_WMDE, WMDE-leszek.Aug 9 2018, 9:41 AM

With masters of core, wikibase, lexeme we seem to be able to reproduce it locally (sometimes; likely cache related).

Error: Module "wikibase.lexeme.datamodel.Lemma" is not loaded.
...
jQuery.Deferred exception: Cannot read property 'buildLexemeHeader' of undefined TypeError: Cannot read property 'buildLexemeHeader' of undefined
    at Object.SELF.getEntityView (<anonymous>:795:934)
    at createEntityView (<anonymous>:648:74)
    at <anonymous>:652:567

• Pablo-WMDE claimed this task.Aug 9 2018, 9:49 AM

Change 451603 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] newLexemeHeaderStore: specify dependencies

https://gerrit.wikimedia.org/r/451603

gerritbot added a project: Patch-For-Review.Aug 9 2018, 9:50 AM

• Pablo-WMDE mentioned this in rEWLEaf377cb05159: newLexemeHeaderStore: specify dependencies.Aug 9 2018, 9:53 AM

• Pablo-WMDE mentioned this in rEWLE0022802ad5de: newLexemeHeaderStore: specify dependencies.Aug 9 2018, 9:57 AM

There appears to be an additional, unrelated flakyness in reading window.mw.config.get( 'LexemeLanguageCodePropertyId' ); possibly before resourceloader is fully finished. -> T201600

Change 451603 merged by Hoo man:
[mediawiki/extensions/WikibaseLexeme@master] newLexemeHeaderStore: specify dependencies

https://gerrit.wikimedia.org/r/451603

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 9 2018, 1:00 PM

• Pablo-WMDE closed this task as Resolved.Aug 9 2018, 1:21 PM

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Editor-Experience-Improvements-Iteration5 board.

Jdforrester-WMF edited projects, added: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:54 PM

selenium: ".lemma-widget_edit" still not visible after 10000msClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

selenium: ".lemma-widget_edit" still not visible after 10000ms
Closed, ResolvedPublic
Actions