Maniphest T202462

[BUG] Missing navigation bar in sub-settings views
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Aug 21 2018, 10:09 PM

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

Open Settings
Tap "Explore Feed"
Start swiping from the left side of the screen to the right to start interactively dismissing the view, but don't go back
Swipe to the left to keep the "Explore feed" settings screen visible

Expected results

Navigation bar is visible, able to go back

Actual results

Navigation bar is invisible, unable to go back, even by swiping

Environments observed

App version: 6.0.1 develop branch

Notes

I'd say for 6.0.1 to revert the 6.0 behavior, then wait to change all the settings VCs to use the navigation bar before changing Settings to match

Related Objects

Mentioned In: rAPIOS11475082f1de: Merge pull request #2599 from wikimedia/bug/T202462

Event Timeline

JoeWalsh created this task.Aug 21 2018, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2018, 10:09 PM

• NHarateh_WMF claimed this task.Aug 22 2018, 12:36 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 22 2018, 12:44 PM

JoeWalsh mentioned this in rAPIOS11475082f1de: Merge pull request #2599 from wikimedia/bug/T202462.Aug 22 2018, 2:49 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 22 2018, 2:58 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 22 2018, 8:04 PM

This is working as expected for me, thanks @NHarateh_WMF!

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Aug 27 2018, 8:50 PM

Testing with Wikipedia 6.0.1 (1483) app and iOS 11.2.2 (iPhone 7). According to the video I'm sharing on Google Drive with @JMinor @JoeWalsh and @NHarateh_WMF swiping in the Settings area seems to not respond to my fingers very sensitively (in articles/pages swiping smoke tests have consistently passed, so it's uniquely in Settings that it is not fixed).

I 'think' this is working on 6.0.1 (1483). My assumption is that there must be more than one language set on the app. In this case, left to right swiping on the customize feed items opens the subscreen as expected and the nav bar is visible.

• JMinor closed this task as Resolved.Sep 24 2018, 10:09 PM

[BUG] Missing navigation bar in sub-settings viewsClosed, ResolvedPublicActions