Page MenuHomePhabricator

[BUG] In the news images have a very wide aspect ratio on iPad
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. On an iPad, tap on a news item in the explore feed
  2. Rotate iPad to landscape
  3. Observe images

Expected results

Reasonable aspect ratio for images

Actual results

IMG_0006.PNG (1×2 px, 1 MB)

Screenshots

Environments observed

App version: 6.0.1 1477
OS versions: 11
Device model: Any iPad
Device language: en

Event Timeline

@JoeWalsh, in the original designs the images were constrained to the same margins as the Header / close button. Perhaps we could update the current implementation to match this design on both portrait and landscape?

PortraitLandscape
208_iPad - Portrait - In the news.png (1×768 px, 460 KB)
208_iPad - landscape - In the news.png (768×1 px, 361 KB)

@JoeWalsh, thanks so much for finding and fixing this! It's looking great! Would it be possible to have the close button be in-line with the (on LTR) right margin of the image on landscape?

JMinor awarded a token.