Page MenuHomePhabricator

Show edit buttons to allow JS enhanced editing
Closed, ResolvedPublic

Description

Motivation
Users should be able to merge versions when they encounter an edit conflict. This should be done in the selected paragraph. However, since people should always know that all paragraphs are in theory editable, both show the edit button, just in different states of activity.

  • If a version is not selected, it shows a deactivated (not clickable) edit icon in gray (#72777D)
  • If a version is selected, it shows an active edit icon in black.
  • If the text block is unchanged text, the edit button is always active
  • The clickable area of the edit button might be bigger then the icon itself ( use the OOui default )

See mock F18567479

We want to introduce nodejs browser tests with the JS editing in the interface, the barebone patch provided by Zjelkof could be used as starting point https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TwoColConflict/+/443117/

The following BDD-ish description could be used as narrative for the browser tests

Narrative
As a user I should be able to merge versions when I encounter an edit conflict

Acceptance Criteria
Given: I am on the merge view
When: A version is not selected
Then: I see a deactivated (not clickable) edit icon in gray (#72777D)

Given: I am on the merge view
When: A version selected
Then: I see an active edit icon in black

Given: I am on the merge view
And: A version selected
When: Text block is unchanged text
Then: The edit button is activated

Given: I am on the merge view
And: A version selected
When: Text block is unchanged text
Then: The edit button is activated
And: I see a clickable area of the edit button bigger than the icon itself

Event Timeline

WMDE-Fisch triaged this task as Normal priority.Aug 30 2018, 7:20 AM
WMDE-Fisch created this task.
WMDE-Fisch updated the task description. (Show Details)Aug 30 2018, 7:23 AM

Change 456365 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Add edit buttons

https://gerrit.wikimedia.org/r/456365

Change 457430 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Add basic browser test for the merge view

https://gerrit.wikimedia.org/r/457430

Change 457430 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Add basic browser test for the merge view

https://gerrit.wikimedia.org/r/457430

Change 456365 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Add edit buttons

https://gerrit.wikimedia.org/r/456365

WMDE-Fisch closed this task as Resolved.Sep 27 2018, 4:18 PM