Page MenuHomePhabricator

Make sure OOUI styles are being used in FormWizard
Closed, ResolvedPublic

Description

When you take out the styles parameter from configuration JSON, forms look like the attached screenshot.

I'm not convinced letting styles be user-defined like this is a good idea, but that aside, the default OOUI styles for form elements should be enforced anyway. The way the elements are closely stacked on top of each other with no padding leads me to believe they aren't.

Screen Shot 2018-09-05 at 15.14.34 .png (1×1 px, 94 KB)

Event Timeline

@Harej We got a class to style the elements in CSS. However, I think some of the object attributes will have to be defined as they were done here.

Change 463978 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[mediawiki/extensions/FormWizard@master] Make sure OOUI styles are being used in FormWizard * Removed User defined styles from javascript module functions. * Applied styles directly in css file.

https://gerrit.wikimedia.org/r/463978

Change 463978 merged by jenkins-bot:
[mediawiki/extensions/FormWizard@master] Make sure OOUI styles are being used in FormWizard * Removed User defined styles from javascript module functions. * Applied styles directly in css file.

https://gerrit.wikimedia.org/r/463978

marking as resolved as issue is solved.