Page MenuHomePhabricator

Doc source and destination directories cannot be identical since Sphinx 1.8.0
Closed, ResolvedPublic

Description

Sphinx updated on Zuul/Integration and this error prevents to pass any doc docker test, see https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/460119/.

Event Timeline

Dalba subscribed.

This is an [[ https://github.com/myint/rstcheck/issues/50 | upstream issue in rstcheck package ]].

As a temporary workaround we can stick with sphinx 1.7.9 until the upstream issue is fixed. Or maybe disable rstcheck?

Change 460198 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] tox.ini: Do not install sphinx 1.8.0 until rstcheck issue is resolved

https://gerrit.wikimedia.org/r/460198

Change 460198 merged by jenkins-bot:
[pywikibot/core@master] docs/requirements-py3.txt: Do not install sphinx 1.8.0

https://gerrit.wikimedia.org/r/460198

Dalba changed the task status from Open to Stalled.Sep 13 2018, 8:00 AM
Dalba triaged this task as Low priority.
Dalba moved this task from Backlog to Upstream issues on the Pywikibot board.
Dalba removed a project: Patch-For-Review.

Waiting for the upstream issue to be resolved, then we can remove the !=1.8.0 limitation from docs/requirements-py3.txt:5.

Xqt changed the task status from Stalled to Open.Sep 22 2018, 10:30 AM
Xqt subscribed.

Same with 1.8.1 and the upstream task was declined.

Change 462124 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [test] docs/requirements-py3.txt: Do not install sphinx >=1.8.0

https://gerrit.wikimedia.org/r/462124

Change 462124 merged by jenkins-bot:
[pywikibot/core@master] [test] docs/requirements-py3.txt: Do not install sphinx >=1.8.0

https://gerrit.wikimedia.org/r/462124

I believe we can remove rstcheck and let Sphinx raise error upon warnings. But before configuring Sphinx to do that, we need to resolve the remaining warnings (T187009).

The issue was resolved in rstcheck 3.3.1, hopefully we can switch on a combination of rstcheck >= 3.3.1 and sphinx >= 1.8 now.

I believe we can remove rstcheck and let Sphinx raise error upon warnings. But before configuring Sphinx to do that, we need to resolve the remaining warnings (T187009).

Yeah, that would be really convenient, only a few errors (129 of former 10 000-15 000) left there.

Change 475037 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] docs/requirements-py3.txt: Use sphinx >= 1.8

https://gerrit.wikimedia.org/r/475037

Change 475037 merged by jenkins-bot:
[pywikibot/core@master] docs/requirements-py3.txt: Use sphinx >= 1.8

https://gerrit.wikimedia.org/r/475037