Page MenuHomePhabricator
Create Task
Maniphest T205087

ORES locks on varnish IPs and not the client IP
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Bump ORES to HEADmediawiki/services/ores/deploymaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Sep 21 2018, 12:25 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 21 2018, 12:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup triaged this task as Unbreak Now! priority.Sep 21 2018, 12:26 PM

That's basically sending 429 to random users.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 21 2018, 12:26 PM
Ladsgroup mentioned this in rORES8536ac2276c4: Pass the real IP.Sep 21 2018, 12:31 PM
Ladsgroup mentioned this in rORES5f8fe71d0a0d: Pass the real IP.Sep 21 2018, 12:38 PM
Ladsgroup added a comment.Sep 21 2018, 12:43 PM

https://github.com/wikimedia/ores/pull/267

gerritbot subscribed.Sep 21 2018, 1:01 PM

Change 461952 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/services/ores/deploy@master] Bump ORES to HEAD

https://gerrit.wikimedia.org/r/461952

gerritbot added a project: Patch-For-Review.Sep 21 2018, 1:01 PM

Change 461952 merged by Ladsgroup:
[mediawiki/services/ores/deploy@master] Bump ORES to HEAD

https://gerrit.wikimedia.org/r/461952

Ladsgroup mentioned this in rORESDEPLOY7b987a7d1d0e: Bump ORES to HEAD.Sep 21 2018, 1:09 PM
Stashbot subscribed.Sep 21 2018, 1:11 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-21T13:11:23Z] <ladsgroup@deploy1001> Started deploy [ores/deploy@7b987a7]: Pass the real IP (T205087)

Stashbot added a comment.Sep 21 2018, 1:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-21T13:35:33Z] <ladsgroup@deploy1001> Finished deploy [ores/deploy@7b987a7]: Pass the real IP (T205087) (duration: 24m 10s)

Ladsgroup closed this task as Resolved.Sep 21 2018, 1:47 PM
Ladsgroup moved this task from Parked to Completed on the Machine-Learning-Team (Active Tasks) board.

Tested with my hammer, if you go above the limit, you get it, if you go below the limit you never get it. Hence this is resolved.

Liuxinyu970226 unsubscribed.Sep 23 2018, 2:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL