Page MenuHomePhabricator
Create Task
Maniphest T205642

Error a.k.toLowerCase is not a function parsing extension token
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.09.27/parsoid?id=AWYb2WlRdq8-Sj2o9LG0&_g=h@44136fa

enwiki Tamil_Nadu_Legislative_Assembly 860986109

TypeError: a.k.toLowerCase is not a function
    at Object.Sanitizer.sanitizeTagAttrs (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/src/lib/wt2html/tt/Sanitizer.js:936:15)
    at Object.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/src/lib/config/extapi.js:64:33)
    at next (native)
    at tryCatchNext (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/prfun/lib/index.js:783:28)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/prfun/lib/index.js:800:24)
    at callback (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/prfun/lib/index.js:812:43)
    at tryCatch1 (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/babybird/lib/promise.js:40:12)
    at promiseReactionJob (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/babybird/lib/promise.js:269:19)
    at PromiseReactionJobTask.call (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/babybird/lib/promise.js:284:3)
    at flush (/srv/deployment/parsoid/deploy-cache/revs/f3ef0c8c3c75ad7693c6c22fd73ff2661ce37297/node_modules/asap/raw.js:50:29)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Details

SubjectRepoBranchLines +/-
Handle callers of parseWikitextToDOM with non-string attribute keysmediawiki/services/parsoidmaster+32 -44
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Sep 27 2018, 4:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2018, 4:37 PM
Arlolra added a comment.Oct 2 2018, 5:54 PM

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.10.02/parsoid?id=AWY16N_-ccmrnEbcxiV7&_g=h@44136fa

Arlolra claimed this task.Oct 3 2018, 10:09 PM
Arlolra triaged this task as Medium priority.
gerritbot subscribed.Oct 3 2018, 10:43 PM

Change 464451 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Handler callers of parseWikitextToDOM with non-string attribute keys

https://gerrit.wikimedia.org/r/464451

gerritbot added a project: Patch-For-Review.Oct 3 2018, 10:43 PM
gerritbot added a comment.Oct 4 2018, 4:19 AM

Change 464451 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Handle callers of parseWikitextToDOM with non-string attribute keys

https://gerrit.wikimedia.org/r/464451

Arlolra closed this task as Resolved.Oct 4 2018, 12:24 PM
Stashbot subscribed.Oct 15 2018, 8:52 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-15T20:52:25Z] <arlolra> Updated Parsoid to 8f3ff40 (T205642, T206003, T187848, T205455, T205743)

Stashbot mentioned this in T206003: Beta Cluster: Parsoid config request failures from the MediaWiki API.Oct 15 2018, 8:52 PM
Stashbot mentioned this in T187848: Fix token transformer return types.
Stashbot mentioned this in T205455: transformTests.js fails to validate QuoteTransformer on a bunch of wiki pages.
Stashbot mentioned this in T205743: parse.js genTest mode emits COMMENT instead of CommentTk.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits