I noticed some definitions in wgMetaNamespaceTalk in InitialiseSettings.php are redundant with NS_PROJECT_TALK from MessagesXxx.php. See atjwiki as an example.
I think we should remove those redundant definitions.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| InitialiseSettings: Remove redundant namespace talks definitions | operations/mediawiki-config | master | +0 -7 |
This link is available only to GCI mentors. Aklapper's link will be public after the contest starts. That's the reason why it is preffered on public places.
@Framawiki @Urbanecm Could you review my patch, please? https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/474372
@takidelfin Looks good to me. You can schedule it for deployment (there's GCI task for it, but it is currently unpublished due to some technical issues on Google side).
Change 474372 had a related patch set uploaded (by Takidelfin; owner: Takidelfin):
[operations/mediawiki-config@master] InitialiseSettings: Remove redundant namespace talks definitions
FTR, https://github.com/takidelfin/redundant-namespaces is the code @takidelfin used.
@Urbanecm Could I schedule it for deployment, please? (At January 7 Morning SWAT)
^-^
Sure, I was just cleaning the backlog of completed site requests in GCI to make sure everyone is deployed. Leaving this to you.
Change 474372 merged by jenkins-bot:
[operations/mediawiki-config@master] InitialiseSettings: Remove redundant namespace talks definitions
Mentioned in SAL (#wikimedia-operations) [2019-01-07T19:51:59Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Remove redundant namespace talk definitions (T206952) (duration: 00m 44s)