Maniphest T207121

gateway.adapter.php triggers warnings on PHP 7.3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 16 2018, 2:50 AM

Description

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /srv/mediawiki/core/extensions/DonationInterface/gateway_common/gateway.adapter.php on line 2462

Details

	Subject	Repo	Branch	Lines +/-
	Use `break` instead of `continue` in a switch block	mediawiki/extensions/DonationInterface	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEDOIca9a1d9fbad7: Fix continue statement breaking tests under PHP 7.3

Event Timeline

Legoktm created this task.Oct 16 2018, 2:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2018, 2:50 AM

Legoktm moved this task from Backlog to Wikimedia production on the PHP 7.3 support board.Oct 16 2018, 2:56 AM

Change 512520 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/DonationInterface@master] Use break instead of continue in a switch block

https://gerrit.wikimedia.org/r/512520

gerritbot added a project: Patch-For-Review.May 26 2019, 9:33 AM

RazeSoldier claimed this task.May 26 2019, 9:44 AM

Change 512520 abandoned by 星耀晨曦:
Use break instead of continue in a switch block

Reason:
Fixed in ca9a1d9.

https://gerrit.wikimedia.org/r/512520

RazeSoldier closed this task as Resolved.May 28 2019, 3:04 PM

RazeSoldier reassigned this task from RazeSoldier to Ejegg.

RazeSoldier subscribed.