Maniphest T20853

Incorrect escaping kills Javascript in Swedish localization
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	May 20 2009, 12:20 PM

Description

Author: lanceskoglund

Description:
The quote around http kills the javascript when you try to add another template. The function validate_field_type fails.

Change the row below in SF_Messages.php

'sf_bad_url_error' => 'måste ha korrekt URL-format, inkluderande "http"'

'sf_bad_url_error' => 'måste ha korrekt URL-format, inkluderande http'

Version: unspecified
Severity: major

Details

Reference: bz18853

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:41 PM

• bzimport added a project: MediaWiki-extensions-Page_Forms.

• bzimport set Reference to bz18853.

• bzimport created this task.May 20 2009, 12:20 PM

Problem is in escaping, not in the localisation, of course.

Looks like SFFormUtils::validationJavascript() needs to make some calls to Xml::escapeJsString()... Likely other functions generating JS with localized text are similarly broken.

Xml::escapeJsString() calls added in Semantic Forms 1.7.

Incorrect escaping kills Javascript in Swedish localizationClosed, ResolvedPublicActions

Description

Details

Event Timeline

Incorrect escaping kills Javascript in Swedish localization
Closed, ResolvedPublic
Actions