Page MenuHomePhabricator
Create Task
Maniphest T208644

Non-continuous StackLayouts should not have a scrollable parent
Closed, ResolvedPublic
Actions

Description

Each page in the stack should be able to manage its own scrolling, preserving its own scroll offset and being allowed to set scrollable:false. If you set the parent layout to scrollable:true (currently the default) this would effectively make every panel scrollable, and share the same scroll offset when switching between pages.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.30.0mediawiki/coremaster+266 -98
[BREAKING CHANGE] Make non-continuous StackLayouts non-scrollableoojs/uimaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Nov 3 2018, 1:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2018, 1:10 PM
gerritbot subscribed.Nov 3 2018, 1:13 PM

Change 465008 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] [BREAKING CHANGE] Make non-continuous StackLayouts non-scrollable

https://gerrit.wikimedia.org/r/465008

gerritbot added a project: Patch-For-Review.Nov 3 2018, 1:13 PM
Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.Nov 5 2018, 10:36 PM
matmarex mentioned this in T210555: Inconsistent scrolling behavior observed for Gallery dialog on Mobile.Dec 11 2018, 10:00 PM
gerritbot added a comment.Dec 20 2018, 3:45 AM

Change 465008 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Make non-continuous StackLayouts non-scrollable

https://gerrit.wikimedia.org/r/465008

gerritbot added a comment.Dec 22 2018, 11:37 AM

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

gerritbot added a comment.Dec 24 2018, 1:51 AM

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Jdforrester-WMF closed this task as Resolved.Jan 1 2019, 4:06 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL