Page MenuHomePhabricator
Create Task
Maniphest T209116

Fix large screen New Pages Feed display to save space (remove empty white-space to condense entries)
Closed, ResolvedPublicFeature
Actions

Assigned To
MPGuy2824
Authored By
Insertcleverphrasehere
Nov 8 2018, 9:42 PM
Tags
Referenced Files
F35825845: image.png
Nov 30 2022, 9:37 PM
F35825843: image.png
Nov 30 2022, 9:37 PM
F35825210: 2022-11-30_023139.png
Nov 30 2022, 10:32 AM
F35813002: image.png
Nov 22 2022, 6:53 AM
F35812994: Newpagesfeedlarge2.png
Nov 22 2022, 6:49 AM
F35812990: Newpagesfeedlarge.png
Nov 22 2022, 6:49 AM
F35812985: Newpagesfeedsmall.png
Nov 22 2022, 6:49 AM
Subscribers
Aklapper
Catrope
Force_Radical
Insertcleverphrasehere
MarioGom
Novem_Linguae

Description

There is a lot of wasted space on the new pages feed. When viewed very zoomed in, it is fine (I guess), and makes use of each line on the left due to test that wraps around. When zoomed out however, it fails to remove this extra line of space, and simply makes each box bigger than it needs to be. The three images at https://en.wikipedia.org/wiki/Wikipedia:Page_Curation/Suggested_improvements#Fix_large_screen_New_Pages_Feed_display_to_save_space (where the problem is also reported at the suggestions page). The third one indicates how the feed could be modified to show more items per page. This would be helpful because it would make it easier to see repeated submissions from the same users, and allow scanning a larger number of pages at the same time.

Image credit to Insertcleverphrasehere, CC BY-SA 4.0:

Zoomed (good):

Newpagesfeedsmall.png (931×1 px, 191 KB)

Wide (bad):

Newpagesfeedlarge.png (485×1 px, 175 KB)

Wide (proposed fix):

Newpagesfeedlarge2.png (470×1 px, 174 KB)

Details

SubjectRepoBranchLines +/-
NewPagesFeed: UI Layout improvementsmediawiki/extensions/PageTriagemaster+163 -130
Customize query in gerrit

Related Objects

Event Timeline

Insertcleverphrasehere created this task.Nov 8 2018, 9:42 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 8 2018, 9:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope moved this task from Inbox to Needs Discussion on the Growth-Team board.Nov 13 2018, 8:38 AM
Catrope moved this task from Needs Discussion to Triaged but Future on the Growth-Team board.Nov 14 2018, 7:02 PM
Catrope subscribed.

Moving this to 'Triaged but future' because many Page Curation tasks are currently part of the 2019 Wishlist Survey

Force_Radical subscribed.Feb 25 2019, 5:00 PM

This looks like a CSS issue which should be pretty simple to fix....I'll investigate when I get some time

Force_Radical claimed this task.Feb 26 2019, 3:12 PM
Force_Radical added a comment.Feb 28 2019, 9:03 AM

On investigation, it's a bit more convoluted than I thought it would be...

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Aklapper removed Force_Radical as the assignee of this task.Jul 2 2021, 5:13 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

MarioGom subscribed.Nov 14 2021, 12:44 PM
MPGuy2824 updated the task description. (Show Details)Nov 22 2022, 6:47 AM
Novem_Linguae updated the task description. (Show Details)Nov 22 2022, 6:49 AM
Novem_Linguae subscribed.Nov 22 2022, 6:53 AM

Looks like this ticket is caused by the HTML using 4 rows to line everything up.

To fix this ticket, would need to rewrite the layout to use 2 columns to line everything up instead. Could be done, but would require some rewriting.

image.png (519×3 px, 139 KB)

Novem_Linguae moved this task from Backlog to Other bugs on the PageTriage board.Nov 22 2022, 6:56 AM
gerritbot added a comment.Nov 23 2022, 8:11 AM

Change 859971 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] NewPagesFeed: UI Layout improvements

https://gerrit.wikimedia.org/r/859971

gerritbot added a project: Patch-For-Review.Nov 23 2022, 8:11 AM
MPGuy2824 moved this task from Other bugs to Code Review on the PageTriage board.Nov 23 2022, 8:35 AM
Novem_Linguae added a comment.EditedNov 30 2022, 10:32 AM

I think I found two regressions in the latest patch.

2022-11-30_023139.png (1×2 px, 341 KB)

The wikitext for regression 1 (Main page) (sic) is:

{{Db-r2}}

The wikitext for regression 2 (Test092679826) is:

tesrttt
tt
{{SFN}}

test
test

The HTML for regression 2 is

<div class="mwe-pt-list-item"><!-- individual list item template -->

	<div class="mwe-pt-article-row mwe-pt-article-row-even">

		<div class="mwe-pt-article-column-right">
			<div class="mwe-pt-info-row">
				
				<div class="mwe-pt-creation-date" title="">
					10:03, 15 October 2022
				</div>
			</div>
			<div class="mwe-pt-info-row">
				<div class="mwe-pt-review">
					<a class="mwe-pt-list-triage-button ui-button-blue ui-button ui-widget ui-state-default ui-corner-all ui-button-text-icon-secondary" style="" href="http://localhost/Code/MediaWiki/core/index.php/Test092679826" target="_blank" title="" role="button" aria-disabled="false"><span class="ui-button-text">Review</span><span class="ui-button-icon-secondary ui-icon ui-icon-triangle-1-e"></span></a>
				</div>
			</div>
			
		</div>
		<div class="mwe-pt-article-column-left">
			<div class="mwe-pt-status-icon">
				
					<img src="/Code/MediaWiki/core/extensions/PageTriage/modules/ext.pageTriage.views.list/images/icon_autopatrolled.png" width="21" height="21">
				
			<div class="mw-tipoff" style="display: none;"><div class="mw-tipoff-pokey"></div>This page was autopatrolled.</div></div>
		</div>
		<div class="mwe-pt-article-column-middle">
			<div class="mwe-pt-info-pane">
				<div class="mwe-pt-info-row">
					<div class="mwe-pt-article">
						<span class="mwe-pt-page-title"><a href="http://localhost/Code/MediaWiki/core/index.php/Test092679826" target="_blank">Test092679826</a></span>
						<span class="mwe-pt-histlink">
							(<a href="/Code/MediaWiki/core/index.php?title=Test092679826&amp;action=history">hist</a>)
						</span>
						<span class="mwe-pt-metadata">
							·
							29 bytes
							·
							9 edits
							
								
									
										· <span class="mwe-pt-metadata-warning">No categories</span>
									
								
								
									· <span class="mwe-pt-metadata-warning">Orphan</span>
								
								
							
							
						</span>
					</div>

				</div>
				<div class="mwe-pt-info-row">
					<div class="mwe-pt-author">
					
						Created by <a href="http://localhost/Code/MediaWiki/core/index.php/User:Novem_Linguae?action=edit&amp;redlink=1" class="new">Novem Linguae</a> (<a href="http://localhost/Code/MediaWiki/core/index.php/User_talk:Novem_Linguae" class="">talk</a> | <a href="http://localhost/Code/MediaWiki/core/index.php/Special:Contributions/Novem_Linguae" class="">contribs</a>)
						<!-- user_id is undefined or '0' for IP users -->
						
							·
							107 edits since 25 July 2022
							
						
						
					
					</div>
					<div class="mwe-pt-updated-date">
						
					</div>
				</div>
				<div class="mwe-pt-info-row">
					<div class="mwe-pt-snippet">
						tesrttt tt test test
					</div>
				</div>
			</div>
			
		</div>
	</div>
</div>
Novem_Linguae added a comment.EditedNov 30 2022, 9:37 PM

I found another possible regression. Please note the location of "potential issues" and "predicted class".

image.png (831×2 px, 155 KB)

Compared to reference image:

image.png (801×1 px, 129 KB)

The review button also lost its vertical-align: middle, although that isn't necessarily a showstopper.

It was a pain to get ORES to display on localhost. I ended up setting includes/SpecialNewPagesFeed.php line 69 to 'wgShowOresFilters' => true,, and I added the following line to modules/ext.pageTriage.views.list/ext.pageTriage.listItem.underscore Line 31: <% ores_draftquality = []; ores_articlequality = []; %>. I may write a patch just to give us a test mode to turn on ORES (T324157)

Novem_Linguae mentioned this in T324157: Display ORES in Special:NewPagesFeed even if not installed (for testing).Nov 30 2022, 9:44 PM
gerritbot added a comment.Dec 1 2022, 1:48 PM

Change 859971 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: UI Layout improvements

https://gerrit.wikimedia.org/r/859971

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 1 2022, 2:00 PM
MPGuy2824 claimed this task.Dec 1 2022, 2:15 PM
MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
MPGuy2824 changed the subtype of this task from "Task" to "Feature Request".
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2022, 2:29 PM
MPGuy2824 closed this task as Resolved.Dec 9 2022, 1:49 PM
MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL