The analysis config for chinese wikis will contain a reference to surrogate merger. Not providing this plugin will prevent us from upgrading to 6.
Since the underlying bug this plugin is designed to fix is fixed we don't need to port the logic but just the declaration of the token filter so that the analysis config created in 5 remains valid in 6.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add noop surrogate_merger as a BC tokenfilter for WMF indices | search/extra | master | +11 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | EBernhardson | T183281 [epic] ELK upgrade to 6.x (elasticsearch, kibana, logstash) | |||
| Resolved | None | T183282 [epic] Search cluster upgrade to 6.x | |||
| Resolved | None | T194199 [Epic] Prepare for Elasticsearch 6 upgrade | |||
| Resolved | dcausse | T209348 Port the elasticsearch plugin extra-analysis-surrogates to 6.4.2 as a noop plugin |
Event Timeline
Comment Actions
Is this necessary? If we have to reindex everything when we upgrade to ES 6, then we should be okay, because the analysis config builder checks for the presence of extra-analysis-surrogates and will configure itself correctly without it. Or is there some interim stage of the upgrade where it needs to exist?
(Either way, thanks for worrying about this!)
Comment Actions
Existing indices will fail to load when ES6 will boot if the token filters they depend on are not available.
Comment Actions
Change 478887 had a related patch set uploaded (by DCausse; owner: DCausse):
[search/extra@master] Add noop surrogate_merger as a BC tokenfilter for WMF indices
Comment Actions
Change 478887 merged by jenkins-bot:
[search/extra@master] Add noop surrogate_merger as a BC tokenfilter for WMF indices