NotificationOverlay in tablet/desktop suffers from margin-left gap
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Nov 22 2018, 7:08 PM

Description

The space to the left of the exit cross in the top left should not be there.

Screen Shot 2018-11-22 at 11.07.47 AM.png (437×529 px, 82 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix notification overlay margins in tablet mode	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Nov 22 2018, 7:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2018, 7:08 PM

Change 475353 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix notification overlay margins in tablet mode

https://gerrit.wikimedia.org/r/475353

gerritbot added a project: Patch-For-Review.Nov 22 2018, 7:11 PM

Jdlrobson triaged this task as Medium priority.Nov 23 2018, 11:47 PM

@Jdlrobson what device/browser are you seeing this on? I just checked on an iPhone/Chrome & Safari and am not seeing this issue.

@alexhollender all browsers on a desktop device.

Jdlrobson renamed this task from NotificationOverlay in tablet suffers from margin-left gap to NotificationOverlay in tablet/desktop suffers from margin-left gap.Dec 11 2018, 5:26 PM

Jdlrobson set the point value for this task to 2.Dec 11 2018, 5:30 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Dec 11 2018, 5:46 PM

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Web-Team-Backlog board.Dec 17 2018, 10:25 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 18 2018, 12:30 AM

Jdrewniak moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 18 2018, 4:17 PM

Change 475353 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix notification overlay margins in tablet mode

https://gerrit.wikimedia.org/r/475353

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 18 2018, 5:00 PM

• alexhollender_WMF claimed this task.Dec 18 2018, 6:09 PM

@Jdlrobson Where should we test this one. It is still reproducible on production

Screen Shot 2018-12-18 at 10.54.17 AM.png (870×1 px, 151 KB)

Beta cluster! Try https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain .

Looks good to me on the beta cluster

Macro catbowtie: Got 'em

	F27629519: Screen Shot 2018-12-18 at 10.54.17 AM.png
	Dec 18 2018, 6:54 PM

	F27281860: Screen Shot 2018-11-22 at 11.07.47 AM.png
	Nov 22 2018, 7:08 PM

	F27629958: image.png
	Dec 18 2018, 8:21 PM

	F27629953: image.png
	Dec 18 2018, 8:21 PM

	F27629947: image.png
	Dec 18 2018, 8:21 PM

	F27629956: image.png
	Dec 18 2018, 8:21 PM

NotificationOverlay in tablet/desktop suffers from margin-left gapClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Event Timeline

NotificationOverlay in tablet/desktop suffers from margin-left gap
Closed, ResolvedPublic2 Estimated Story Points
Actions