Page MenuHomePhabricator

NotificationOverlay in tablet/desktop suffers from margin-left gap
Closed, ResolvedPublic2 Story Points

Description

The space to the left of the exit cross in the top left should not be there.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2018, 7:08 PM

Change 475353 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix notification overlay margins in tablet mode

https://gerrit.wikimedia.org/r/475353

Jdlrobson triaged this task as Normal priority.Nov 23 2018, 11:47 PM

@Jdlrobson what device/browser are you seeing this on? I just checked on an iPhone/Chrome & Safari and am not seeing this issue.

@alexhollender all browsers on a desktop device.

Jdlrobson renamed this task from NotificationOverlay in tablet suffers from margin-left gap to NotificationOverlay in tablet/desktop suffers from margin-left gap.Dec 11 2018, 5:26 PM
Jdlrobson set the point value for this task to 2.Dec 11 2018, 5:30 PM

Change 475353 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix notification overlay margins in tablet mode

https://gerrit.wikimedia.org/r/475353

@Jdlrobson Where should we test this one. It is still reproducible on production