Visual diff assumes extension nodes have body attribute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Nov 23 2018, 12:26 PM

Description

The visual diff crashes if it encounters an extension node with no body attribute, e.g. from a self-closing map tag.

Details

	Subject	Repo	Branch	Lines +/-
	ve.dm.MWExtensionNode: check for body in describeChanges	mediawiki/extensions/VisualEditor	master	+6 -4

Customize query in gerrit

Event Timeline

Tchanders created this task.Nov 23 2018, 12:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2018, 12:26 PM

Change 475460 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] ve.dm.MWExtensionNode: check for body in describeChanges

https://gerrit.wikimedia.org/r/475460

gerritbot added a project: Patch-For-Review.Nov 23 2018, 12:35 PM

Change 475460 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.dm.MWExtensionNode: check for body in describeChanges

https://gerrit.wikimedia.org/r/475460

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 23 2018, 3:00 PM

• marcella edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 26 2018, 3:41 PM

• marcella moved this task from Incoming to QA on the VisualEditor (Current work) board.

Ryasmeen added a project: Editing QA.Nov 26 2018, 6:53 PM

Esanders moved this task from Inbox to Low Priority on the Editing QA board.Nov 26 2018, 10:22 PM

Ryasmeen added a project: Verified.Jan 11 2019, 10:47 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• marcella closed this task as Resolved.Jan 15 2019, 2:28 PM

Visual diff assumes extension nodes have body attributeClosed, ResolvedPublicActions

Description

Details

Event Timeline

Visual diff assumes extension nodes have body attribute
Closed, ResolvedPublic
Actions