Page MenuHomePhabricator
Create Task
Maniphest T210344

“⧼advancedsearch-field-inlanguage⧽” in AdvancedSearch form (message broken?)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

On this search page, the inlanguage parameter is displayed to me as “⧼advancedsearch-field-inlanguage⧽” instead of “Pages in this language”.

Screenshot_2018-11-25 Search results for Etats-Unis inlanguage fr - Wikidata.png (69×700 px, 7 KB)

The message MediaWiki:advancedsearch-field-inlanguage exists, so I’m not sure why this is happening. But if this form is assembled client-side, then perhaps there’s some ResourceLoader setup missing to make sure that message is also available in JavaScript?

Details

SubjectRepoBranchLines +/-
Add missing i18n to load for the lazy load interfacemediawiki/extensions/AdvancedSearchmaster+1 -0
Add advancedsearch-field-inlanguage to ext.advancedSearch.elementsmediawiki/extensions/AdvancedSearchmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 25 2018, 11:12 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 25 2018, 11:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-11-20.Nov 27 2018, 7:46 AM
Lea_WMDE subscribed.

Can you please look into this? :)

Lea_WMDE moved this task from Backlog to In FUN sprint on the Advanced-Search board.Nov 27 2018, 7:47 AM
gerritbot subscribed.Nov 27 2018, 10:21 AM

Change 475982 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Add missing i18n to load for the lazy load interface

https://gerrit.wikimedia.org/r/475982

gerritbot added a project: Patch-For-Review.Nov 27 2018, 10:21 AM
WMDE-Fisch claimed this task.Nov 27 2018, 10:22 AM
WMDE-Fisch set the point value for this task to 2.
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.
WMDE-Fisch mentioned this in rEASR1a07629cb85d: Add missing i18n to load for the lazy load interface.Nov 27 2018, 10:23 AM
gerritbot added a comment.Nov 27 2018, 10:29 AM

Change 475983 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Add advancedsearch-field-inlanguage to ext.advancedSearch.elements

https://gerrit.wikimedia.org/r/475983

Lucas_Werkmeister_WMDE mentioned this in rEASR0063086e5b5b: Add advancedsearch-field-inlanguage to ext.advancedSearch.elements.Nov 27 2018, 10:32 AM
gerritbot added a comment.Nov 27 2018, 10:53 AM

Change 475982 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Add missing i18n to load for the lazy load interface

https://gerrit.wikimedia.org/r/475982

gerritbot added a comment.Nov 27 2018, 10:56 AM

Change 475983 abandoned by Lucas Werkmeister (WMDE):
Add advancedsearch-field-inlanguage to ext.advancedSearch.elements

Reason:
see I8dae13d205

https://gerrit.wikimedia.org/r/475983

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 27 2018, 11:00 AM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-11-20 board.Nov 27 2018, 1:00 PM

Can be tested on beta.wikidata

https://wikidata.beta.wmflabs.org/w/index.php?search=inlanguage%3Aaln&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current=%7B%22options%22%3A%7B%22inlanguage%22%3A%22aln%22%7D%2C%22namespaces%22%3A%5B120%2C0%5D%7D&ns120=1&ns0=1

Lea_WMDE closed this task as Resolved.Dec 3 2018, 9:00 AM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-11-20 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL