SelectFileWidget: Use 'clear' icon for clear button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Nov 30 2018, 5:25 PM

Description

As of v0.29.5, SelectFileWidget uses 'close' icon for clear input functionality.
We need to

use 'clear' icon similar to any other input treatment, exemplified SearchInputWidget,

fix positioning of button (WikimediaUI theme)
fix padding of file name
update demos to use different indicator icon for demo

Update 2018-12-15
It makes more sense to make use of the 'clear' icon for button interactive area here.

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.30.2	mediawiki/core	master	+677 -544
	themes: Use 'clear' icon for clearing SelectFileWidget's input	oojs/ui	master	+31 -14

Customize query in gerrit

Event Timeline

Volker_E created this task.Nov 30 2018, 5:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2018, 5:25 PM

Volker_E updated the task description. (Show Details)Nov 30 2018, 5:25 PM

Volker_E renamed this task from SelectFileWidget: Use 'clear' indicator to SelectFileWidget: Use 'clear' icon for clear button.Dec 15 2018, 11:29 PM

Volker_E updated the task description. (Show Details)

Change 483331 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Use 'clear' icon for clearing SelectFileWidget's input

https://gerrit.wikimedia.org/r/483331

gerritbot added a project: Patch-For-Review.Jan 10 2019, 3:03 AM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jan 10 2019, 3:46 AM

Change 483331 merged by jenkins-bot:
[oojs/ui@master] themes: Use 'clear' icon for clearing SelectFileWidget's input

https://gerrit.wikimedia.org/r/483331

Volker_E closed this task as Resolved.Jan 14 2019, 8:54 PM

Volker_E claimed this task.

Volker_E triaged this task as Medium priority.

Volker_E moved this task from Reviewing to OOUI-0.30.2 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

gerritbot added a project: Patch-For-Review.Jan 23 2019, 7:04 PM

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Volker_E removed a project: Patch-For-Review.Feb 21 2019, 3:48 AM

SelectFileWidget: Use 'clear' icon for clear buttonClosed, ResolvedPublicActions

Description

Details

Event Timeline

SelectFileWidget: Use 'clear' icon for clear button
Closed, ResolvedPublic
Actions