Page MenuHomePhabricator
Create Task
Maniphest T211134

Backfill unit tests for T205891
Closed, ResolvedPublic
Actions

Description

T205891 introduced some functionality that wasn't covered by unit tests. Write the tests to cover it

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+487 -150tests: Test moving the captions block on the File page
Customize query in gerrit

Related Objects

Event Timeline

Cparle created this task.Dec 4 2018, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2018, 5:57 PM
Jdforrester-WMF awarded a token.Dec 4 2018, 6:02 PM
gerritbot added a subscriber: gerritbot.Dec 10 2018, 6:08 PM

Change 478737 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Add missing unit tests

https://gerrit.wikimedia.org/r/478737

gerritbot added a project: Patch-For-Review.Dec 10 2018, 6:08 PM
Cparle mentioned this in rEWBIe3e60e64ab4b: Add missing unit tests.Dec 10 2018, 6:11 PM
Cparle mentioned this in rEWBI810d9de13af3: Add missing unit tests.Dec 11 2018, 12:38 PM
Jdforrester-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Dec 11 2018, 7:34 PM
Cparle mentioned this in rEWBI5c5f066b6014: Add missing unit tests.Dec 12 2018, 1:22 PM
Cparle mentioned this in rEWBIf58aacc9849a: Add missing unit tests.Dec 12 2018, 2:19 PM
Cparle moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Dec 12 2018, 2:21 PM
Cparle mentioned this in rEWBI2bc856e77c51: Add missing unit tests.Dec 12 2018, 3:11 PM
Cparle mentioned this in rEWBI8daf1f03866c: Add missing unit tests.Dec 12 2018, 3:46 PM
Jdforrester-WMF closed this task as Resolved.Dec 12 2018, 4:37 PM
Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed Patch-For-Review.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Code-only change.

Jdforrester-WMF mentioned this in rEWBIa1f61c56de78: tests: Test moving the captions block on the File page.Dec 12 2018, 4:38 PM
gerritbot added a comment.Dec 12 2018, 5:00 PM

Change 478737 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] tests: Test moving the captions block on the File page

https://gerrit.wikimedia.org/r/478737

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL