Page MenuHomePhabricator
Create Task
Maniphest T211154

Deprecate passing string IDs to OO.ui.infuse
Closed, ResolvedPublic
Actions

Description

We generally discourage the use of IDs elsewhere in our code, so we should remove this special case for ID inputs. In makes for confusing reading when put alongside class selectors:

widget1 = OO.ui.infuse( 'widget1' );
widget2 = OO.ui.infuse( $( '.widget2' ) );

instead this should be:

widget1 = OO.ui.infuse( $( '#widget1' ) );
widget2 = OO.ui.infuse( $( '.widget2' ) );

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.30.0mediawiki/coremaster+266 -98
Avoid deprecated OO.ui.infuse( id )oojs/uimaster+3 -3
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/WikibaseLexememaster+3 -3
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/TwoColConflictmaster+8 -8
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/UrlShortenermaster+2 -2
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/Newslettermaster+1 -1
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/PageAssessmentsmaster+1 -1
Avoid deprecated OO.ui.infuse( id )mediawiki/extensions/ForcePreviewmaster+2 -2
Avoid deprecated OO.ui.infuse( id )mediawiki/coremaster+5 -5
Deprecate passing string IDs to infuseoojs/uimaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Dec 4 2018, 10:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2018, 10:28 PM
gerritbot subscribed.Dec 4 2018, 10:32 PM

Change 477690 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Deprecate passing string IDs to infuse

https://gerrit.wikimedia.org/r/477690

gerritbot added a project: Patch-For-Review.Dec 4 2018, 10:32 PM
Esanders added subscribers: matmarex, Volker_E.Dec 4 2018, 10:34 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Dec 5 2018, 4:07 PM
gerritbot added a comment.Dec 10 2018, 7:37 PM

Change 477690 merged by jenkins-bot:
[oojs/ui@master] Deprecate passing string IDs to infuse

https://gerrit.wikimedia.org/r/477690

gerritbot added a comment.Dec 10 2018, 7:50 PM

Change 478752 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478752

gerritbot added a comment.Dec 10 2018, 7:50 PM

Change 478754 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/TwoColConflict@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478754

Esanders mentioned this in rESCC3a9d7b712362: Avoid deprecated OO.ui.infuse( id ).Dec 10 2018, 7:53 PM
gerritbot added a comment.Dec 10 2018, 7:54 PM

Change 478756 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ForcePreview@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478756

gerritbot added a comment.Dec 10 2018, 8:11 PM

Change 478766 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikibaseLexeme@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478766

Esanders mentioned this in rEWLE1136592ce16a: Avoid deprecated OO.ui.infuse( id ).Dec 10 2018, 8:12 PM
gerritbot added a comment.Dec 10 2018, 8:27 PM

Change 478752 merged by jenkins-bot:
[mediawiki/core@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478752

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 10 2018, 9:00 PM
gerritbot added a comment.Dec 10 2018, 9:09 PM

Change 478756 merged by jenkins-bot:
[mediawiki/extensions/ForcePreview@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478756

gerritbot added a comment.Dec 10 2018, 9:55 PM

Change 478791 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/UrlShortener@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478791

gerritbot added a comment.Dec 10 2018, 10:08 PM

Change 478794 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Newsletter@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478794

gerritbot added a comment.Dec 10 2018, 10:24 PM

Change 478796 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/PageAssessments@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478796

gerritbot added a comment.Dec 10 2018, 10:33 PM

Change 478796 merged by jenkins-bot:
[mediawiki/extensions/PageAssessments@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478796

gerritbot added a comment.Dec 10 2018, 10:34 PM

Change 478794 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478794

gerritbot added a comment.Dec 10 2018, 10:35 PM

Change 478791 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478791

gerritbot added a comment.Dec 11 2018, 8:46 AM

Change 478754 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478754

gerritbot added a comment.Dec 11 2018, 12:07 PM

Change 478906 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478906

Esanders mentioned this in rEWLE369634c35af9: Avoid deprecated OO.ui.infuse( id ).Dec 11 2018, 3:30 PM
gerritbot added a comment.Dec 11 2018, 3:53 PM

Change 478766 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478766

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 11 2018, 4:00 PM
gerritbot added a comment.Dec 11 2018, 4:08 PM

Change 478906 merged by jenkins-bot:
[oojs/ui@master] Avoid deprecated OO.ui.infuse( id )

https://gerrit.wikimedia.org/r/478906

Volker_E moved this task from Reviewing to OOUI-0.30.0 on the OOUI board.Dec 18 2018, 10:42 PM
Volker_E edited projects, added OOUI (OOUI-0.30.0); removed OOUI.
Esanders added a comment.EditedDec 18 2018, 10:45 PM
mwgrep "\.infuse\("
commonswiki         MediaWiki:Gadget-advanced-search.js
dewiki              MediaWiki:Gadget-old-movepage.js
hewiki              MediaWiki:Nosaving.js
huwiki              MediaWiki:Gadget-QPreview.js
jawiki              MediaWiki:Common.js/titleChecker.js
jawiki              MediaWiki:Vector.js
plwiki              MediaWiki:Gadget-sk.js
plwikibooks         MediaWiki:Gadget-sk.js
plwikinews          MediaWiki:Gadget-sk.js

Not all of these will be passing string.

Esanders added a comment.Dec 18 2018, 11:20 PM

Fixed all on-wiki uses.

gerritbot added a comment.Dec 22 2018, 11:37 AM

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

gerritbot added a comment.Dec 24 2018, 1:51 AM

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Jdforrester-WMF closed this task as Resolved.Jan 1 2019, 4:07 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits