Page MenuHomePhabricator

ComboBoxInputWidget: Label button and add `aria-controls` hint to it
Closed, ResolvedPublic

Description

As of v0.29.6, ComboBoxInputWidget has two remaining issues on a pure technical best-practices label (let alone the different hardships in the current implementation with varying screen reader support, where for example triggering the dropdown by enter comes to mind):

  • button should feature a label
  • button should have aria-controls added

Event Timeline

Volker_E triaged this task as Normal priority.Dec 16 2018, 4:30 AM
Volker_E created this task.

Change 479972 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] ComboBoxInputWidget: Add 'label' and aria-controls attribute to button

https://gerrit.wikimedia.org/r/479972

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Dec 16 2018, 11:16 PM

Change 479972 merged by jenkins-bot:
[oojs/ui@master] ComboBoxInputWidget: Add 'label' and aria-controls attribute to button

https://gerrit.wikimedia.org/r/479972

Volker_E closed this task as Resolved.Dec 17 2018, 10:38 PM
Volker_E moved this task from Reviewing to OOUI-0.30.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.0); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E removed a subscriber: gerritbot.

Change 481239 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239

Change 481239 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.0

https://gerrit.wikimedia.org/r/481239