The Recommendation-API service returns 404 in case there's a DB connection error. 500 with details of what happened would be more appropriate. The returned error should also follow RFC7807 (see T209164)
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • schana | T148129 Productization of Recommendation API | |||
| Resolved | • bmansurov | T212156 Recommendation API service returns 404 on DB connection error |
Event Timeline
Comment Actions
500 with details of what happened would be more appropriate.
I would argue that also setting a retry threshold would be a good idea. Say, retry to connect 2, 3 times before returning the error.
Comment Actions
Change 482089 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Retry MySQL query in case of error
Comment Actions
Change 482096 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api/deploy@master] Add MySQL retry config variables
Comment Actions
Change 482096 merged by Ppchelko:
[mediawiki/services/recommendation-api/deploy@master] Add MySQL retry config variables
Comment Actions
Change 482089 merged by Ppchelko:
[mediawiki/services/recommendation-api@master] Retry MySQL query in case of error