Page MenuHomePhabricator

width for td.mw-label causes issues
Closed, ResolvedPublic

Assigned To
Authored By
bzimport
Jun 15 2009, 7:39 PM
Referenced Files
F5732: Screenshot-1.png
Jul 11 2020, 1:22 PM
F5736: prefwidth.diff
Nov 21 2014, 10:38 PM
F5737: Special_Upload_mw-label_problem_huwiki.png
Nov 21 2014, 10:38 PM
F5735: prefs-30-precent.png
Nov 21 2014, 10:38 PM
F5734: prefs-20-precent.png
Nov 21 2014, 10:38 PM
F5733: Screenshot-2.png
Nov 21 2014, 10:38 PM

Description

Author: ahmad.m.sherif

Description:
screenshot of the problem

in rSVN51868, the value of width was changed from 20% to 30% for some adjustment and stuff. Unfortunately, this cases some labels as in Special:RecentChangesLinked to look over-margined as you can see in this attachment.

Another thing, changing this value was because 'at' in "Display pages starting at:" (Special:AllPages) appears in new line. Well, 'at' still there in a new line on my machine. And when changing the value to 25% the sentence appears in single line.

So, 'at' problem seems to be machine-dependent somehow, and it causes some visual problems the same time.

I suggest reverting to the old value.


Version: 1.16.x
Severity: trivial
URL: http://en.wikipedia.org/wiki/Special:RecentChangesLinked

Attached:

Screenshot-1.png (422×1 px, 68 KB)

Details

Reference
bz19225

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:38 PM
bzimport set Reference to bz19225.

ahmad.m.sherif wrote:

AllPages screenshot

Screenshot of Special:AllPages to show the position of 'at'

Attached:

Screenshot-2.png (451×1 px, 82 KB)

It seems neither is a good solution, nor is changing it to 25%, because other forms will get issues. Getting rid of it altogether, as it was before r49790 is also an option[1]. According to the designer of the revised preferences, Special:Preferences may suffer, though. Which is the least of all evils, or what is a proper solution?

Adding Andrew to cc.

[1] http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?r1=49544&r2=49790&pathrev=51868

The columns should be the same width, and it should be reasonably narrow. It is hideous on some pages when there are multiple form tables and the columns have different widths. It is also hideous when there is a long description.

Created attachment 6227
Prefs with 20% width

Prefs with 20% width. Also uploading 30% width. Neither will win a design competition. Screenshot in Windows Xp with Firefox 3.0.11

Attached:

prefs-20-precent.png (657×1 px, 46 KB)

Created attachment 6228
Prefs with 30% width

Attached:

prefs-30-precent.png (663×1 px, 47 KB)

Is there a way to change the mw-label to mw-label-preference use 20/25/30% in preferences only, and revert to the old behaviour in the rest of core (no width)? Also got a report that Special:Email is affected.

ahmad.m.sherif wrote:

proposed patch

(In reply to comment #6)

Is there a way to change the mw-label to mw-label-preference use 20/25/30% in
preferences only, and revert to the old behaviour in the rest of core (no
width)? Also got a report that Special:Email is affected.

Or something like this?

Attached:

Created attachment 6243
Special:Upload screenshot

Special:Upload looks quite horrible too. It is a bad idea to apply the same spacing to a number of different interfaces.

Attached:

Special_Upload_mw-label_problem_huwiki.png (622×1 px, 35 KB)

Assigning to Andrew. Proposed patch looks OK, doesn't it?

Patch applied with modifications in r52737.

rockmfr wrote:

Why do tables have width: 100% applied to them? This broke stuff on enwiki's prefs page (see [[en:MediaWiki:Gadgets-prefstext]]).