Page MenuHomePhabricator
Create Task
Maniphest T213769

Zero VCL removal
Closed, ResolvedPublic
Actions

Description

Task for removal of carrier tagging and other VCL code specific to Wikipedia Zero decommissioning.

Details

SubjectRepoBranchLines +/-
vcl: do not set WP Zero X-Carrier headersoperations/puppetproduction+0 -84
varnish: remove WP Zero puppetizationoperations/puppetproduction+1 -241
vcl: remove WP Zero codeoperations/puppetproduction+18 -77
Revert "Block WP Zero users from accessing Phabricator uploads"operations/puppetproduction+1 -81
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT106123 Extensions needing to be removed from Wikimedia wikis
 ResolvedJdforrester-WMFT187716 Sunset Wikipedia Zero
 Resolved• emaT213769 Zero VCL removal

Event Timeline

Jdforrester-WMF triaged this task as Medium priority.Jan 14 2019, 10:59 PM
Jdforrester-WMF created this task.
Restricted Application added a project: SRE. · View Herald TranscriptJan 14 2019, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF mentioned this in T187716: Sunset Wikipedia Zero.Jan 14 2019, 10:59 PM
gerritbot subscribed.Jan 14 2019, 11:00 PM

Change 479399 had a related patch set uploaded (by Jforrester; owner: MaxSem):
[operations/puppet@production] Revert "Block WP Zero users from accessing Phabricator uploads"

https://gerrit.wikimedia.org/r/479399

gerritbot added a project: Patch-For-Review.Jan 14 2019, 11:00 PM
• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 11:05 PM
• ema moved this task from Backlog to Caching on the Traffic board.Mar 6 2019, 9:36 AM
jbond subscribed.May 9 2019, 3:07 PM

Is this ticket complete? can it be closed, if not what further actions are required?

Reedy subscribed.May 9 2019, 3:24 PM
In T213769#5170303, @jbond wrote:

Is this ticket complete? can it be closed, if not what further actions are required?

I guess the removal needs merging?

In T213769#4879139, @gerritbot wrote:

Change 479399 had a related patch set uploaded (by Jforrester; owner: MaxSem):
[operations/puppet@production] Revert "Block WP Zero users from accessing Phabricator uploads"

https://gerrit.wikimedia.org/r/479399

jbond added a comment.May 9 2019, 3:25 PM

I guess the removal needs merging?

Oh yes missed that :D

Jdforrester-WMF added a comment.May 9 2019, 3:37 PM

I was told by Traffic that the removal is blocked on something in SRE land, but I don't know enough to even give pointers, sorry.

BBlack added a comment.May 9 2019, 3:47 PM

Yeah, it's mostly just blocked on us making some time to deal with it, and time has been in extremely short supply lately, so we tend not to prioritize anything that doesn't have imminent impact. There's some subtleties to backing out that stuff in stages and not breaking things.

Jdforrester-WMF added a comment.May 9 2019, 3:48 PM

Yeah, this is definitely not urgent, just tech debt clean-up and RelEng (though it will simplify life for Analytics when they don't have to worry about this stuff any more, I understand).

jbond added a comment.May 9 2019, 3:53 PM

Ok great thanks for the update

• ema changed the task status from Open to Stalled.Jul 4 2019, 11:56 AM
• ema subscribed.
In T213769#5170476, @BBlack wrote:

Yeah, it's mostly just blocked on us making some time to deal with it, and time has been in extremely short supply lately, so we tend not to prioritize anything that doesn't have imminent impact. There's some subtleties to backing out that stuff in stages and not breaking things.

Setting the task as stalled for now.

gerritbot added a comment.Jul 9 2019, 1:04 PM

Change 521488 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: stop calling WP Zero subroutines

https://gerrit.wikimedia.org/r/521488

gerritbot added a comment.Jul 9 2019, 1:05 PM

Change 479399 had a related patch set uploaded (by Ema; owner: MaxSem):
[operations/puppet@production] Revert "Block WP Zero users from accessing Phabricator uploads"

https://gerrit.wikimedia.org/r/479399

• ema changed the task status from Stalled to Open.Jul 9 2019, 1:27 PM
gerritbot added a comment.Jul 9 2019, 1:27 PM

Change 479399 merged by Ema:
[operations/puppet@production] Revert "Block WP Zero users from accessing Phabricator uploads"

https://gerrit.wikimedia.org/r/479399

gerritbot added a comment.Jul 9 2019, 2:21 PM

Change 521510 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] varnish: remove WP Zero puppetization

https://gerrit.wikimedia.org/r/521510

gerritbot added a comment.Jul 9 2019, 2:25 PM

Change 521511 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: do not set WP Zero X-Carrier headers

https://gerrit.wikimedia.org/r/521511

gerritbot added a comment.Jul 10 2019, 12:56 PM

Change 521488 merged by Ema:
[operations/puppet@production] vcl: remove WP Zero code

https://gerrit.wikimedia.org/r/521488

gerritbot added a comment.Jul 10 2019, 1:07 PM

Change 521510 merged by Ema:
[operations/puppet@production] varnish: remove WP Zero puppetization

https://gerrit.wikimedia.org/r/521510

gerritbot added a comment.Jul 10 2019, 1:14 PM

Change 521511 merged by Ema:
[operations/puppet@production] vcl: do not set WP Zero X-Carrier headers

https://gerrit.wikimedia.org/r/521511

Stashbot added a comment.Jul 10 2019, 1:47 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-10T13:47:58Z] <ema> cp hosts: cleanup WP zero leftovers T213769

• ema closed this task as Resolved.Jul 10 2019, 1:55 PM
• ema claimed this task.

This is now done!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits