Page MenuHomePhabricator
Create Task
Maniphest T214391

Remove tmpMaxItemIdForNew(Item|property)IdHtmlFormatter options & legacy code from Wikibase
Closed, ResolvedPublic
Actions

Description

This includes:

  • Changing the default unconfigured behaviour of Wikibase to use the cache backed formatters (as if both settings were ∞)
  • Remove the config variables from Wikibase & code looking at the vars (default to the new route)

The settings will be removed from wmf production in T213713 once this step is complete.

The Wikibase config vars are:

  • tmpMaxPropertyIdForNewItemIdHtmlFormatter
  • tmpMaxItemIdForNewItemIdHtmlFormatter

Details

SubjectRepoBranchLines +/-
Drop tmpMaxItemIdForNew(Item|property)IdHtmlFormattermediawiki/extensions/Wikibasemaster+13 -150
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore triaged this task as Low priority.Jan 22 2019, 2:25 PM
Addshore created this task.
Addshore mentioned this in T213713: Remove tmpMaxItemIdForNew(Item|property)IdHtmlFormatter options & legacy code paths.
gerritbot subscribed.Jan 22 2019, 6:05 PM

Change 485865 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Drop tmpMaxItemIdForNew(Item|property)IdHtmlFormatter

https://gerrit.wikimedia.org/r/485865

gerritbot added a project: Patch-For-Review.Jan 22 2019, 6:05 PM
Ladsgroup claimed this task.Jan 22 2019, 6:05 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2019, 6:05 PM
Addshore updated the task description. (Show Details)Jan 23 2019, 10:26 AM
gerritbot added a comment.Jan 23 2019, 2:31 PM

Change 485865 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop tmpMaxItemIdForNew(Item|property)IdHtmlFormatter

https://gerrit.wikimedia.org/r/485865

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 23 2019, 2:33 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 23 2019, 3:00 PM
Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jan 30 2019, 11:55 AM
Addshore closed this task as Resolved.Feb 4 2019, 9:38 AM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL