Page MenuHomePhabricator

Allow coordinators to see unavailable partners they are assigned to
Closed, ResolvedPublic

Description

Task

When adding new partners we may want to show the page to the person who will be coordinating it, for proofreading and other setup before the partner is made available. Currently, however, only staff can view unavailable partner pages (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/resources/views.py#L55).

To fix this:

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 triaged this task as Medium priority.Feb 5 2019, 2:04 PM

The build failed on Travis:

The command "docker-compose exec twlight /app/bin/virtualenv_test.sh" exited with 1.

But I don't see where I did something wrong.

We've recently implemented a robust code formatter – Black, which is causing your code to fail since there are files that needs formatting. You'll need an interactive bash shell (docker exec -it <container_id> bash or an equivalent docker-compose command) within which you'll need to run black -t py37 . before your tests will pass.

@Samwalton9 shouldn't coordinators be able to see the not available partner on the browse partner page as well? Or am I missing something?