Page MenuHomePhabricator

Table border collapse in Timeless
Closed, ResolvedPublic


Timeless uses the property "border-collapse:collapse;", that causes an issue with custom css for tables like the property "border-radius".

Event Timeline

ashley added subscribers: Isarra, ashley.

Hi @Roumpf, do you have some screenshots of this issue and/or URLs to example pages where the problem is happening? Thanks!

Also had this issue. As a temporary workaround, go to the MediaWiki:Timeless.css page on your wiki and add:

table {
  border-collapse: separate;

To reproduce this issue, simply try creating a table with rounded borders on a wiki:

{| style="border: 2px solid red; border-radius: 5px;"
! Header !! Header
| Cell || Cell

The expected result is rounded corners. The actual result is square corners. This works fine on non-Timeless skins because Timeless is the only one that has:

table {
  border-collapse: collapse;

If there isn't a valid reason for Timeless to have that property, please remove it.

The reason for the border collapse was to get 1px borders between the cells instead of 2px, but evidently the default wikitable styles don't need that, which is interesting...

Izno renamed this task from Table borders to Table border collapse in Timeless.Mar 17 2019, 6:49 AM
Izno moved this task from Backlog to Change CSS on the CSS board.

Change 532285 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Kill weird table normalisation

Change 532285 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Kill weird table normalisation

Isarra claimed this task.