Description

I notice the figures in the table for the Event List pages are not always accurate.

They have a column hanging off the end with no title, and the data in the columns appears to match the header of the column to its left.

It looks as if the columns have been shifted one to the right, but the headers have not been moved. Or, the third column is being duplicated in the fourth column.

Reproduction:

For example, see stats from https://eventmetrics-dev.wmflabs.org/programs/118 (annotated in screenshot)

event_list_columns_out_of_alignment_annotated.png (613×1 px, 61 KB)

Or the first row of https://eventmetrics-dev.wmflabs.org/programs/78 has the same number of participants and new editors (769) but according to the event summary there are 351 new editors for that event.

Event List showing just event 150:

Event Summary for event 150:

event_summary_aftest.png (455×1 px, 14 KB)

Related Objects

Mentioned In: T216640: Add new command to update all events
T206692: Implement ‘Event Summary’ downloadable Wikitext report
rGEVM163de52226f7: Don't manually include participants as a stat, is done automatically
rGEVM830ecf595b71: Don't manually include participants as a stat, is done automatically
rGEVM216326d0125e: Don't manually include participants as a stat, is done automatically
Mentioned Here: T208546: Create a method to derive the number of 'Participants' and 'New Editors'
T206692: Implement ‘Event Summary’ downloadable Wikitext report

Event Timeline

dom_walden created this task.Feb 19 2019, 4:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2019, 4:44 PM

Same issue as T206692#4963802. Recently we started storing the Participants as a stat, so it automatically shows. There was still some code in there that manually showed it, hence the duplication/misalignment.

PR: https://github.com/wikimedia/eventmetrics/pull/189

MusikAnimal moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Feb 19 2019, 9:38 PM

Not quite ready...

MusikAnimal mentioned this in rGEVM216326d0125e: Don't manually include participants as a stat, is done automatically.Feb 19 2019, 9:41 PM

MusikAnimal mentioned this in rGEVM830ecf595b71: Don't manually include participants as a stat, is done automatically.Feb 19 2019, 9:47 PM

MusikAnimal mentioned this in rGEVM163de52226f7: Don't manually include participants as a stat, is done automatically.Feb 19 2019, 10:07 PM

Okay, ready for review now :) PR: https://github.com/wikimedia/eventmetrics/pull/189

Note that events created before the time T208546 was merged will need an update, since it's looking for the pre-stored participant count now. I am going to try to write a script to automate this. For testing purposes, just make sure you run "Update data" first :)

Hey @MusikAnimal, go ahead and assign points to this ticket.

MusikAnimal set the point value for this task to 1.Feb 19 2019, 10:10 PM

MusikAnimal mentioned this in T206692: Implement ‘Event Summary’ downloadable Wikitext report.

Merged and ready for QA.

I have compared the numbers in the Event List tables against the numbers in the Event Summary (incl. events which were not updated before T208546) for a selection of events. The numbers in all the columns matched (after updating the event's data).

MusikAnimal mentioned this in T216640: Add new command to update all events.Feb 20 2019, 6:22 PM

• jmatazzoni closed this task as Resolved.Feb 20 2019, 9:42 PM

• jmatazzoni moved this task from Product sign-off to Q3 2018-19 on the Community-Tech-Sprint board.

	F28246790: event_list_columns_out_of_alignment_annotated.png
	Feb 19 2019, 4:44 PM

Table columns out of alignment on "Event List"Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Related Objects

Event Timeline

Table columns out of alignment on "Event List"
Closed, ResolvedPublic1 Estimated Story Points
Actions