There was the problem that there is nothing gained if a user activates "all" by default (since the pills are so many that any other space saving is small in comparison). However, it seems that "Articles" is the default, which means it makes sense.

Change 495922 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Collapse namespace panel by defaul

https://gerrit.wikimedia.org/r/495922

I just saw some tracking code in the ExpandablePane class, which is reused. This might skew our tracking of "Advanced search expanded/collapsed" as it will now also track namespace expands/collapses. Should we do a more fine-grained tracking, @Lea_WMDE?

Change 496414 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Improve generateTag function after OOUI provided a fix

https://gerrit.wikimedia.org/r/496414

Change 496414 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Improve generateTag function after OOUI provided a fix

https://gerrit.wikimedia.org/r/496414

Change 498912 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Track namespaces and search optoions expandable panes separately

https://gerrit.wikimedia.org/r/498912

@Lea_WMDE @Jan_Dittrich

In the mocks provided for this change the checkbox [] Remember selection for future searches is in the header of the expandable namespaces pane and it appears only when the pane is expanded.
Unfortunately that creates quite a few headaches for the development. For some reason the CheckBox's click event is hijacked by the expandable pane's click event which means when you try to click [] Remember selection for future searches the pane collapses. We would have to invest some more time and resources to figure out how to get around that.

How about we put that checkbox above the presets, in the actual expandable part? Like in the screenshots below:

How about we put that checkbox above the presets, in the actual expandable part? Like in the screenshots below:

Not super nice looking, but fine with me…
(It is a bit of a tricky UI with lots of compromises/tricks already so changes are likely to have ripple effects (like the one encountered))

I'm wondering if it would look at least a little bit better, if the line was moved to below the selection (i.e. just before the Add namespaces input field), logically I guess it makes more sense to first see what you select, and then decide that you want to have that selection as a default.
@Jan_Dittrich what do you think?

if the line was moved to below the selection

I assume "line" here refers to a "line of text", in this case "[ ] Remember selection for future searches".

So the order now is:

• Header Search in
• Save Selection
• Presets
• Selected Namespaces
• Namespace addition

and with your suggestion change to:

• Header Search in
• Presets
• Selected Namespaces
• Save Selection
• Namespace addition

The reasoning is fine (though I am unsure of first… then I… in this case eases understanding for the users), but by that change we create a new problem: Then, the connection between "add namespace" and the namespace list to which we add is broken up.

We could move it to the very end,

• Header Search in
• Presets
• Selected Namespaces
• Namespace addition
• Save Selection

It looks a bit striped then, though and the change have further ripple effects due to the interconnections of the elements.

Change 495922 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Collapse namespace panel by default

https://gerrit.wikimedia.org/r/495922

Change 498912 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Track namespaces and search options expandable panes separately

https://gerrit.wikimedia.org/r/498912