Page Forms: Checkboxes should be farther apart
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yaron_Koren
	Mar 3 2019, 5:12 PM

Description

Right now, the "checkboxes" display looks a little ugly - labels are actually closer to the checkbox ahead of them than to their own checkbox. There needs to be more space between each checkbox + label pair and the next - ideally defined in the file PageForms.css.

Details

	Subject	Repo	Branch	Lines +/-
	Page Forms: Checkboxes should be farther apart	mediawiki/extensions/PageForms	master	+8 -0
	Fix The Appearance of Checkboxes	mediawiki/extensions/PageForms	master	+16 -1

Customize query in gerrit

Related Objects

Mentioned In: T248505: Proposal: Remove use of jQuery UI from Page Forms
rEPFM81271a78aded: Fix The Appearance of Checkboxes
T241632: Remove use of jQuery UI from Page Forms
T220521: GSoC 2019 Proposal: T213759: Page Forms: add an editable calendar interface
T220515: GSoC 2019 Proposal: T213513: Improve the interface of Special:ViewData in the Cargo extension
rEPFM21fe8bdc463e: Page Forms: Checkboxes should be farther apart
rEPFM60b8f5ae5d41: Page Forms: Checkboxes should be farther apart
rEPFM14bbee146944: Page Forms: Checkboxes should be farther apart
rEPFMe54f8234488c: Page Forms: Checkboxes should be farther apart
rEPFM930f58ae8125: Page Forms: Checkboxes should be farther apart
T213759: Page Forms: add an editable calendar interface

Event Timeline

Yaron_Koren created this task.Mar 3 2019, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2019, 5:12 PM

Yaron_Koren mentioned this in T213759: Page Forms: add an editable calendar interface.Mar 3 2019, 5:14 PM

Gopavasanth claimed this task.Mar 3 2019, 5:28 PM

yashdeep97 subscribed.Mar 4 2019, 8:24 PM

Gopavasanth removed Gopavasanth as the assignee of this task.Mar 10 2019, 6:02 AM

Gopavasanth subscribed.

Smanmand subscribed.Mar 11 2019, 8:03 PM

DrishyaR claimed this task.Mar 12 2019, 12:46 PM

priyanshu_varshney subscribed.Mar 19 2019, 5:56 AM

Yaron_Koren removed DrishyaR as the assignee of this task.Mar 20 2019, 11:36 AM

Yaron_Koren added a subscriber: DrishyaR.

Change 497766 had a related patch set uploaded (by Drishya Ramesh; owner: Drishya Ramesh):
[mediawiki/extensions/PageForms@master] Page Forms: Checkboxes should be farther apart

https://gerrit.wikimedia.org/r/497766

gerritbot added a project: Patch-For-Review.Mar 20 2019, 1:35 PM

DrishyaR mentioned this in rEPFMe54f8234488c: Page Forms: Checkboxes should be farther apart.Mar 21 2019, 12:24 AM

DrishyaR mentioned this in rEPFM930f58ae8125: Page Forms: Checkboxes should be farther apart.

DrishyaR mentioned this in rEPFM14bbee146944: Page Forms: Checkboxes should be farther apart.Mar 23 2019, 3:31 PM

DrishyaR mentioned this in rEPFM21fe8bdc463e: Page Forms: Checkboxes should be farther apart.Apr 2 2019, 3:07 PM

DrishyaR mentioned this in rEPFM60b8f5ae5d41: Page Forms: Checkboxes should be farther apart.

DrishyaR mentioned this in T220515: GSoC 2019 Proposal: T213513: Improve the interface of Special:ViewData in the Cargo extension.Apr 9 2019, 2:56 PM

DrishyaR mentioned this in T220521: GSoC 2019 Proposal: T213759: Page Forms: add an editable calendar interface.Apr 9 2019, 3:32 PM

Yaron_Koren mentioned this in T241632: Remove use of jQuery UI from Page Forms.Jan 16 2020, 2:25 PM

Hello @Yaron_Koren is this still an Issue? which check boxes are referred to here? the ones on Special:CreateClass?

Yes, this is still an issue. This refers to checkboxes in user-defined forms, defined with "input type=checkboxes".

Hello @Yaron_Koren I understand this task, but how can i check it out myself?

@Rexsteroxy: See https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker or https://www.mediawiki.org/wiki/Gerrit/Tutorial (depends on what you mean by "check it out").

@Rexsteroxy - you need to set up MediaWiki and install Page Forms on it, if I understand the question correctly...

Thanks @Yaron_Koren . Let me set it up.

Thanks @Aklapper . The links really helped.

Hello @Yaron_Koren I have succeeded in setting up MediaWiki and as well installed the Page Forms Extensions.

Above is the screen shot of the page form extension.
On which of the above links can i see the stipulated error.("checkboxes" display looks a little ugly ).

Great! Now you need to create a form that includes an input with type "checkboxes". Look at the Page Forms documentation for how to do that:

https://www.mediawiki.org/wiki/Extension:Page_Forms

Ok, will do that.

Hi @Yaron_Koren
I've contacted you through G-Mail and you guided me to this Microtasks.
I've installed Media Wiki, PageForms and Cargo, but I faced a problem to generate a "Checkbox". Using the Special Pages (Special:Createform, Special:CreateTemplate, Special:CreateClass and Special:CreateCategory) didn't lead me to generate it.
On the Other hand, I partly familiarized myself with the jQuery Code in extensions/PageForms/libs/PF_CreateTemplate.js

So I hope you may guide me to the lost item to reach the Checkbox.
Thanks.

@AmrEl-Absy - did you read the Page Forms documentation? Everything with checkboxes is explained there...

Hi @Yaron_Koren
I think I completed it. I had a problem to to know that boolean datatype leads to CheckBox.
I have changed a little bit in extensions/PageForms/skins/PageForms.css Line 135
It was

#pfForm select,
#pfForm input[type="checkbox"] {
    min-width: 0;
    max-width: 100%;
    width: auto !important;
}

So I changed The min-width to 30px and added new property margin-top: 6px.
I think I did this microtask, but I don't know how to submit it or even claim it ti myself. So, I hope you would help me through submitting it.
Thanks.

Hi @AmrEl-Absy - that's not quite it. There are two different input types, "checkbox" and "checkboxes" - this issue is about "checkboxes". Sorry for the confusion.

Hi @Yaron_Koren
Never mind, I think I fixed it.

This is Before

And this is After

This Microtask was a little tricky because of the direction but I noticed that <body> has a class .ltr, so I used it in the CSS Selector.
The Change would be in the same file, extensions/PageForms/skins/PageForms.css, and I think it goes on Line 143.

The Selector should consider using all the checkboxes but the first one, so it goes in the following way

body.ltr #pfForm label.checkboxLabel:not(:first-child) input[type="checkbox"] {
	margin-left: 40px;
}

body.rtl #pfForm label.checkboxLabel:not(:first-child) input[type="checkbox"] {
	margin-right: 40px;
}

I hope it's right that time, and hope you will help me through submitting it, and tell me the next suitable step, whether going to another microtask, or something else.
Thanks.

In T217517#5962663, @AmrEl-Absy wrote:
Hi @Yaron_Koren
Never mind, I think I fixed it.

This is Before

And this is After

This Microtask was a little tricky because of the direction but I noticed that <body> has a class .ltr, so I used it in the CSS Selector.
The Change would be in the same file, extensions/PageForms/skins/PageForms.css, and I think it goes on Line 143.

The Selector should consider using all the checkboxes but the first one, so it goes in the following way
body.ltr #pfForm label.checkboxLabel:not(:first-child) input[type="checkbox"] {
	margin-left: 40px;
}

body.rtl #pfForm label.checkboxLabel:not(:first-child) input[type="checkbox"] {
	margin-right: 40px;
}
I hope it's right that time, and hope you will help me through submitting it, and tell me the next suitable step, whether going to another microtask, or something else.
Thanks.

Hello @AmrEl-Absy I am guessing you are interested in GSoC, with wikimedia, if So you have to get used to making code contributions yourself. I am sure with some trial and error you will be able to do it! here is a link on making contributions to mediawiki, you should look out for the Gerrit Tutorial here. If you have any issues you can ask questions here or on the support channel, Best of luck.

In T217517#5962901, @Prondubuisi wrote:

Hello @AmrEl-Absy I am guessing you are interested in GSoC, with wikimedia, if So you have to get used to making code contributions yourself. I am sure with some trial and error you will be able to do it! here is a link on making contributions to mediawiki, you should look out for the Gerrit Tutorial here. If you have any issues you can ask questions here or on the support channel, Best of luck.

Thanks a million. I have followed the instructions, and submitted the changes to Gerrit. Is that only what I am asked to finish this Microtask?! and what should I do now for getting deeper in GSoC Proposal Requirements or what is the next step?!
Thanks

What is the URL for the Gerrit patch?

In T217517#5966427, @Yaron_Koren wrote:

What is the URL for the Gerrit patch?

It's here.

Change 579694 had a related patch set uploaded (by Amr El-Absy; owner: Amr El-Absy):
[mediawiki/extensions/PageForms@master] Fix The Appearance of Checkboxes

https://gerrit.wikimedia.org/r/579694

Gopavasanth unsubscribed.Mar 15 2020, 4:57 AM

Change 579694 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Fix The Appearance of Checkboxes

https://gerrit.wikimedia.org/r/579694

Yaron_Koren mentioned this in rEPFM81271a78aded: Fix The Appearance of Checkboxes.Mar 17 2020, 11:24 PM

Fixed now! @AmrEl-Absy - thank you!

AmrEl-Absy mentioned this in T248505: Proposal: Remove use of jQuery UI from Page Forms.Mar 25 2020, 7:41 PM

Change 497766 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageForms@master] Page Forms: Checkboxes should be farther apart

Reason:

T217517 appears to be resolved by now.