Page MenuHomePhabricator

Uncaught exception from Special:SetSchemaLabelDescriptionAliases if aliases are duplicated
Closed, ResolvedPublic


If one enters duplicated aliases (like a|b|a) on Special:SetSchemaLabelDescriptionAliases, an uncaught exception will appear when trying to save the changes.

Acceptance criteria

  • When setting duplicate aliases, the process wont be disrupted by an uncaught exception.

Event Timeline

hoo created this task.Mar 6 2019, 11:01 AM

We could silently remove duplicates or show an error message in case duplicates are entered. IMO we should just silently discard duplicates in the special page.

Michael edited projects, added Wikidata; removed WikiProject-ShEx.Mar 6 2019, 12:54 PM

Change 494801 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Remove duplicate aliases in SetSchemaLabelDescriptionAliases

hoo closed this task as Resolved.Mar 6 2019, 8:18 PM
hoo removed a project: Patch-For-Review.
hoo moved this task from Peer Review to Done on the Shape Expressions Sprint 3 board.

Change 494801 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Remove duplicate aliases in SetSchemaLabelDescriptionAliases