Page MenuHomePhabricator
Create Task
Maniphest T217749

Uncaught exception from Special:SetSchemaLabelDescriptionAliases if aliases are duplicated
Closed, ResolvedPublic
Actions

Description

If one enters duplicated aliases (like a|b|a) on Special:SetSchemaLabelDescriptionAliases, an uncaught exception will appear when trying to save the changes.

Acceptance criteria

  • When setting duplicate aliases, the process wont be disrupted by an uncaught exception.

Details

SubjectRepoBranchLines +/-
Remove duplicate aliases in SetSchemaLabelDescriptionAliasesmediawiki/extensions/WikibaseSchemamaster+21 -0
Customize query in gerrit

Event Timeline

hoo created this task.Mar 6 2019, 11:01 AM

We could silently remove duplicates or show an error message in case duplicates are entered. IMO we should just silently discard duplicates in the special page.

Michael edited projects, added Wikidata; removed WikiProject-ShEx.Mar 6 2019, 12:54 PM
Lucas_Werkmeister_WMDE claimed this task.Mar 6 2019, 6:05 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 3 board.
gerritbot subscribed.Mar 6 2019, 6:20 PM

Change 494801 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Remove duplicate aliases in SetSchemaLabelDescriptionAliases

https://gerrit.wikimedia.org/r/494801

gerritbot added a project: Patch-For-Review.Mar 6 2019, 6:20 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Shape Expressions Sprint 3 board.Mar 6 2019, 6:20 PM
hoo closed this task as Resolved.Mar 6 2019, 8:18 PM
hoo removed a project: Patch-For-Review.
hoo moved this task from Peer Review to Done on the Shape Expressions Sprint 3 board.
gerritbot added a comment.Mar 6 2019, 8:20 PM

Change 494801 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Remove duplicate aliases in SetSchemaLabelDescriptionAliases

https://gerrit.wikimedia.org/r/494801

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL