Page MenuHomePhabricator
Create Task
Maniphest T218577

Save changes made using the Termbox
Closed, ResolvedPublic
Actions

Description

  • trigger a save action from the save button
  • add a save action to the entity store module
  • within the action
    • if necessary, convert the store state to the format expected by wbeditentity
    • make a request against wbeditentity with the edited data
  • switch back to reading mode
  • sending and updating the base revision id is not part of this task => T218578

Details

SubjectRepoBranchLines +/-
Add action for saving labels, descriptions and aliases of an entitywikibase/termboxmaster+233 -7
Make mw.config.values.wbRepo accessible on mobilemediawiki/extensions/Wikibasemaster+3 -0
Provide Wikibase URL in dev view for API requestswikibase/termboxmaster+13 -1
mockup-entry: add origin param to dev API callswikibase/termboxmaster+15 -0
Introduce a request interceptor for API requests needing CSRF tokenswikibase/termboxmaster+160 -0
Transform post request payload to FormData objectwikibase/termboxmaster+34 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT215515 Termbox Editing Mode
 OpenNoneT215522 Switch from reading into editing mode
 ResolvedLea_WMDET216987 Allow editing of fields
 ResolvedJakob_WMDET218577 Save changes made using the Termbox

Event Timeline

Jakob_WMDE created this task.Mar 18 2019, 2:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 2:23 PM
Jakob_WMDE updated the task description. (Show Details)Mar 18 2019, 2:24 PM
Jakob_WMDE updated the task description. (Show Details)Mar 18 2019, 2:32 PM
• Pablo-WMDE edited projects, added Wikidata-Termbox-Iteration-11; removed Wikidata-Termbox.Mar 18 2019, 3:06 PM
Jakob_WMDE claimed this task.Mar 19 2019, 11:45 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-11 board.
gerritbot subscribed.Mar 19 2019, 4:40 PM

Change 497548 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Add action for saving labels, descriptions and aliases of an entity

https://gerrit.wikimedia.org/r/497548

gerritbot added a project: Patch-For-Review.Mar 19 2019, 4:40 PM
• Pablo-WMDE subscribed.Mar 20 2019, 11:52 AM

We mentioned axios interceptors when discussing the challenge of access tokens

gerritbot added a comment.Mar 20 2019, 5:43 PM

Change 497819 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce a request interceptor for API requests needing CSRF tokens

https://gerrit.wikimedia.org/r/497819

gerritbot added a comment.Mar 22 2019, 1:37 PM

Change 498374 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce a request interceptor for API requests needing CSRF tokens

https://gerrit.wikimedia.org/r/498374

gerritbot added a comment.Mar 22 2019, 5:38 PM

Change 498435 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Make mw.config.values.wbRepo accessible on mobile

https://gerrit.wikimedia.org/r/498435

• Pablo-WMDE added a project: Wikidata-Termbox-Iteration-12-OLD.Mar 25 2019, 11:36 AM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-12-OLD board.
• Pablo-WMDE added a project: Wikidata-Termbox-Iteration-12 ✓.Mar 25 2019, 3:11 PM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-12 ✓ board.
• Pablo-WMDE removed a project: Wikidata-Termbox-Iteration-12-OLD.Mar 25 2019, 6:18 PM
gerritbot added a comment.Mar 25 2019, 10:10 PM

Change 499000 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] mockup-entry: add origin param to dev API calls

https://gerrit.wikimedia.org/r/499000

gerritbot added a comment.Mar 26 2019, 12:12 PM

Change 499178 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Provide Wikibase URL in dev view for API requests

https://gerrit.wikimedia.org/r/499178

gerritbot added a comment.Mar 26 2019, 2:42 PM

Change 497819 merged by jenkins-bot:
[wikibase/termbox@master] Transform post request payload to FormData object

https://gerrit.wikimedia.org/r/497819

gerritbot added a comment.Mar 26 2019, 2:43 PM

Change 498374 merged by jenkins-bot:
[wikibase/termbox@master] Introduce a request interceptor for API requests needing CSRF tokens

https://gerrit.wikimedia.org/r/498374

gerritbot added a comment.Mar 26 2019, 4:52 PM

Change 499000 merged by jenkins-bot:
[wikibase/termbox@master] mockup-entry: add origin param to dev API calls

https://gerrit.wikimedia.org/r/499000

gerritbot added a comment.Mar 26 2019, 4:55 PM

Change 499178 merged by jenkins-bot:
[wikibase/termbox@master] Provide Wikibase URL in dev view for API requests

https://gerrit.wikimedia.org/r/499178

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-12 ✓ board.Mar 27 2019, 10:21 AM
gerritbot added a comment.Mar 27 2019, 10:31 AM

Change 498435 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make mw.config.values.wbRepo accessible on mobile

https://gerrit.wikimedia.org/r/498435

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 11:00 AM
gerritbot added a comment.Mar 27 2019, 3:19 PM

Change 497548 merged by jenkins-bot:
[wikibase/termbox@master] Add action for saving labels, descriptions and aliases of an entity

https://gerrit.wikimedia.org/r/497548

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-12 ✓ board.Mar 27 2019, 3:20 PM
• Pablo-WMDE updated the task description. (Show Details)Mar 28 2019, 12:38 PM
• Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL