Page MenuHomePhabricator

Invalid callback HitCounters\Hooks:onAbuseFilterGenerateTitleVars in hooks for AbuseFilter-generateTitleVars due to typos in "extension.json"
Closed, ResolvedPublic

Description

Setup

  • MW 1.32+

Issue
Originally reported and suggested here.

wrong;

		"AbuseFilter-generateTitleVars": [
			"HitCounters\\Hooks:onAbuseFilterGenerateTitleVars"
		],
		"AbuseFilter-computeVariable": [
			"HitCounters\\Hooks:onAbuseFilterComputeVariable"
		]

right:

		"AbuseFilter-generateTitleVars": [
			"HitCounters\\Hooks::onAbuseFilterGenerateTitleVars"
		],
		"AbuseFilter-computeVariable": [
			"HitCounters\\Hooks::onAbuseFilterComputeVariable"
		]

@Huji Lee I assigned this to you since you moved in the respective changes.

@MarkAHershberger FYI

Event Timeline

Kghbln created this task.Mar 23 2019, 12:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2019, 12:02 PM

The fix should probably be backported to the active MW branches most importantly to REL1_31 (LTS9

Change 500223 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/HitCounters@master] Fix callbacks in extension.json

https://gerrit.wikimedia.org/r/500223

Change 500224 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/HitCounters@REL1_32] Fix callbacks in extension.json

https://gerrit.wikimedia.org/r/500224

Change 500223 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@master] Fix callbacks in extension.json

https://gerrit.wikimedia.org/r/500223

Change 500224 merged by jenkins-bot:
[mediawiki/extensions/HitCounters@REL1_32] Fix callbacks in extension.json

https://gerrit.wikimedia.org/r/500224

Kghbln closed this task as Resolved.Mar 31 2019, 4:41 PM
Kghbln triaged this task as Medium priority.
Kghbln removed a project: Patch-For-Review.

@matej_suchanek Thanks a ton and indeed no need to back-port to REL1_31 since it was not in there.