Page MenuHomePhabricator
Create Task
Maniphest T219749

WDQS GUI test broken after merging 2144a682d48168555368d8aa5df1bd9dfa369fb2
Closed, ResolvedPublic
Actions

Description

After merging 2144a682d48168555368d8aa5df1bd9dfa369fb2, when WDQS GUI is tested as part of WDQS CI test, I get this:

21:07:01 [INFO] Running "wdio" task
21:07:01 [INFO] Starting up http-server, serving ./
21:07:01 [INFO] Available on:
21:07:01 [INFO]   http://127.0.0.1:8082
21:07:01 [INFO]   http://172.17.0.2:8082
21:07:01 [INFO] Hit CTRL-C to stop the server
21:07:01 [ERROR] /src/gui/node_modules/selenium-standalone/bin/selenium-standalone:79
21:07:01 [ERROR]         throw err;
21:07:01 [ERROR]         ^
21:07:01 [ERROR] 
21:07:01 [ERROR] Error: Missing /src/gui/node_modules/selenium-standalone/.selenium/chromedriver/2.43-x64-chromedriver
21:07:01 [ERROR]     at /src/gui/node_modules/selenium-standalone/lib/check-paths-existence.js:15:20
21:07:01 [ERROR]     at FSReqWrap.cb [as oncomplete] (fs.js:311:19)
21:07:02 [INFO] 
21:07:02 [INFO] ERROR: connect ECONNREFUSED 127.0.0.1:4444
21:07:02 [INFO] firefox
21:07:02 [INFO]     at new RuntimeError (/src/gui/node_modules/webdriverio/build/lib/utils/ErrorHandler.js:143:12)
21:07:02 [INFO]     at Request._callback (/src/gui/node_modules/webdriverio/build/lib/utils/RequestHandler.js:330:43)
21:07:02 [INFO]     at self.callback (/src/gui/node_modules/webdriverio/node_modules/request/request.js:185:22)
21:07:02 [INFO]     at emitOne (events.js:115:13)
21:07:02 [INFO]     at Request.emit (events.js:210:7)
21:07:02 [INFO]     at Request.onRequestError (/src/gui/node_modules/webdriverio/node_modules/request/request.js:881:8)
21:07:02 [INFO]     at emitOne (events.js:120:20)
21:07:02 [INFO]     at ClientRequest.emit (events.js:210:7)
21:07:02 [INFO]     at Socket.socketErrorListener (_http_client.js:400:9)
21:07:02 [INFO]     at emitOne (events.js:115:13)
21:07:02 [INFO] 
21:07:02 [INFO] 
21:07:02 [INFO] http-server stopped.
21:07:02 [INFO] Warning: Task "wdio" failed. Use --force to continue.
21:07:02 [INFO]

Not sure what exactly is missing, but seems to be broken.

Details

SubjectRepoBranchLines +/-
Merging from 528d333273c19da91105d7a17e6c248bc6803ca1:wikidata/query/gui-deployproduction+2 -2
Updated gui submodulewikidata/query/rdfmaster+1 -1
Remove wdio tests from gui query servive grunt test taskwikidata/query/guimaster+1 -1
Separate browser tests from rest of tests in the Query Service GUI CIwikidata/query/guimaster+6 -2
Merging from 8fff7b801d67e7e612556dda133c1824a32073ca:wikidata/query/gui-deployproduction+5 -5
Remove 'test' Grunt task from 'create_build' taskwikidata/query/guimaster+2 -2
Attempt other browser for wdio browser testwikidata/query/guimaster+1 -1
Update GUIwikidata/query/rdfmaster+1 -1
Set up selenium-standalone before testwikidata/query/guimaster+29 -22
Customize query in gerrit

Related Objects

Event Timeline

Smalyshev created this task.Apr 1 2019, 6:43 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 1 2019, 6:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher added a project: Wikidata-Campsite.Apr 1 2019, 8:29 AM
Lucas_Werkmeister_WMDE subscribed.EditedApr 1 2019, 10:32 AM

I can reproduce the issue locally in the GUI repository.

$ namei /home/luwe/git/wikidata-query-gui/node_modules/selenium-standalone/.selenium/chromedriver/2.43-x64-chromedriver
f: /home/luwe/git/wikidata-query-gui/node_modules/selenium-standalone/.selenium/chromedriver/2.43-x64-chromedriver                                                          
 d /
 d home
 d luwe
 d git
 d wikidata-query-gui
 d node_modules
 d selenium-standalone
   .selenium - No such file or directory
Lucas_Werkmeister_WMDE added a comment.Apr 1 2019, 10:36 AM

Apparently we need to run selenium-standalone install at some point?

gerritbot added a comment.Apr 1 2019, 10:43 AM

Change 500414 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Set up selenium-standalone before test

https://gerrit.wikimedia.org/r/500414

gerritbot added a project: Patch-For-Review.Apr 1 2019, 10:43 AM
Lucas_Werkmeister_WMDE mentioned this in rWDQG12ea07659624: Set up selenium-standalone before test.Apr 1 2019, 10:51 AM
gerritbot added a comment.Apr 1 2019, 5:24 PM

Change 500414 merged by jenkins-bot:
[wikidata/query/gui@master] Set up selenium-standalone before test

https://gerrit.wikimedia.org/r/500414

Smalyshev added a comment.EditedApr 1 2019, 6:30 PM

Now I get this:

17:42:14 [INFO] Selenium started
17:42:14 [ERROR] 17:42:14.826 INFO [ActiveSessionFactory.apply] - Capabilities are: {
17:42:14 [ERROR]   "browserName": "firefox",
17:42:14 [ERROR]   "handlesAlerts": true,
17:42:14 [ERROR]   "javascriptEnabled": true,
17:42:14 [ERROR]   "locationContextEnabled": true,
17:42:14 [ERROR]   "loggingPrefs": {
17:42:14 [ERROR]     "browser": "ALL",
17:42:14 [ERROR]     "driver": "ALL"
17:42:14 [ERROR]   },
17:42:14 [ERROR]   "maxInstances": 5,
17:42:14 [ERROR]   "requestOrigins": {
17:42:14 [ERROR]     "url": "http:\u002f\u002fwebdriver.io",
17:42:14 [ERROR]     "version": "4.13.1",
17:42:14 [ERROR]     "name": "webdriverio"
17:42:14 [ERROR]   },
17:42:14 [ERROR]   "rotatable": true
17:42:14 [ERROR] }
17:42:14 [ERROR] 17:42:14.828 INFO [ActiveSessionFactory.lambda$apply$11] - Matched factory org.openqa.selenium.grid.session.remote.ServicedSession$Factory (provider: org.openqa.selenium.firefox.GeckoDriverService)
17:42:15 [INFO] ERROR: Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line
17:42:15 [INFO] Build info: version: '3.141.5', revision: 'd54ebd709a', time: '2018-11-06T11:58:47'
17:42:15 [INFO] System info: host: 'b44963709ea5', ip: '172.17.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.9.0-0.bpo.8-amd64', java.version: '1.8.0_181'
17:42:15 [INFO] Driver info: driver.version: unknown
17:42:15 [INFO] remote stacktrace: 
17:42:15 [INFO] firefox
17:42:15 [INFO]     at new RuntimeError (/src/gui/node_modules/webdriverio/build/lib/utils/ErrorHandler.js:143:12)
17:42:15 [INFO]     at Request._callback (/src/gui/node_modules/webdriverio/build/lib/utils/RequestHandler.js:316:39)
17:42:15 [INFO]     at Request.self.callback (/src/gui/node_modules/webdriverio/node_modules/request/request.js:185:22)
17:42:15 [INFO]     at emitTwo (events.js:125:13)
17:42:15 [INFO]     at Request.emit (events.js:213:7)
17:42:15 [INFO]     at Request.<anonymous> (/src/gui/node_modules/webdriverio/node_modules/request/request.js:1161:10)
17:42:15 [INFO]     at emitOne (events.js:115:13)
17:42:15 [INFO]     at Request.emit (events.js:210:7)
17:42:15 [INFO]     at IncomingMessage.<anonymous> (/src/gui/node_modules/webdriverio/node_modules/request/request.js:1083:12)
17:42:15 [INFO]     at Object.onceWrapper (events.js:314:30)
17:42:15 [INFO] 
17:42:15 [INFO] 
17:42:15 [INFO] http-server stopped.
17:42:15 [INFO] Warning: Task "wdio" failed. Use --force to continue.

https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker/837/console

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Apr 2 2019, 10:49 AM
Smalyshev triaged this task as High priority.Apr 2 2019, 5:31 PM
gerritbot added a comment.Apr 3 2019, 12:18 AM

Change 500361 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/rdf@master] Update GUI

https://gerrit.wikimedia.org/r/500361

Smalyshev removed a project: Patch-For-Review.Apr 3 2019, 12:19 AM
Smalyshev added a comment.Apr 3 2019, 11:36 PM

GUI is still not mergeable, so I think I'll disable running wdio test on CI for now.

gerritbot added a comment.Apr 4 2019, 12:01 AM

Change 500361 abandoned by Smalyshev:
Update GUI

https://gerrit.wikimedia.org/r/500361

noarave claimed this task.Apr 8 2019, 12:44 PM
Restricted Application added a project: User-Noarave. · View Herald TranscriptApr 8 2019, 12:44 PM
noarave edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Apr 9 2019, 7:45 AM
noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Apr 9 2019, 8:49 AM

Change 500361 restored by Noa wmde:
Update GUI

https://gerrit.wikimedia.org/r/500361

gerritbot added a comment.Apr 9 2019, 8:49 AM

Change 500361 abandoned by Noa wmde:
Update GUI

https://gerrit.wikimedia.org/r/500361

gerritbot added a comment.Apr 9 2019, 8:51 AM

Change 502447 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[wikidata/query/gui@master] Attempt other browser for wdio browser test

https://gerrit.wikimedia.org/r/502447

gerritbot added a project: Patch-For-Review.Apr 9 2019, 8:51 AM
noarave mentioned this in rWDQGe6e8236fcf27: Attempt other browser for wdio browser test.Apr 9 2019, 8:54 AM
noarave mentioned this in rWDQGf3b920fc2756: Attempt other browser for wdio browser test.Apr 9 2019, 9:21 AM
noarave mentioned this in rWDQG45dfbaa0ff26: Attempt other browser for wdio browser test.Apr 9 2019, 9:30 AM
gerritbot added a comment.Apr 9 2019, 11:47 AM

Change 502447 abandoned by Noa wmde:
Attempt other browser for wdio browser test

https://gerrit.wikimedia.org/r/502447

gerritbot added a comment.Apr 9 2019, 12:31 PM

Change 502475 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[wikidata/query/gui@master] Remove 'test' Grunt task from 'create_build' task

https://gerrit.wikimedia.org/r/502475

noarave mentioned this in rWDQGad336491cd3d: Remove 'test' Grunt task from 'create_build' task.Apr 9 2019, 12:32 PM
noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 9 2019, 12:35 PM
noarave mentioned this in rWDQG8fff7b801d67: Remove 'test' Grunt task from 'create_build' task.Apr 9 2019, 12:35 PM
gerritbot added a comment.Apr 9 2019, 6:10 PM

Change 502475 merged by jenkins-bot:
[wikidata/query/gui@master] Remove 'test' Grunt task from 'create_build' task

https://gerrit.wikimedia.org/r/502475

gerritbot added a comment.Apr 9 2019, 6:13 PM

Change 502566 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 8fff7b801d67e7e612556dda133c1824a32073ca:

https://gerrit.wikimedia.org/r/502566

gerritbot added a comment.Apr 9 2019, 6:51 PM

Change 502566 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 8fff7b801d67e7e612556dda133c1824a32073ca:

https://gerrit.wikimedia.org/r/502566

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 10 2019, 7:23 AM
Smalyshev added a comment.Apr 11 2019, 12:44 AM

The latest patch doesn't seem to help, because test is run by pom.xml as it seems. Please see full log in https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker/850/console

noarave moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 11 2019, 9:45 AM
gerritbot added a comment.Apr 16 2019, 10:40 AM

Change 504287 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[wikidata/query/gui@master] Separate browser tests from rest of tests in the Query Service GUI CI

https://gerrit.wikimedia.org/r/504287

noarave mentioned this in rWDQG38f501f026fd: Separate browser tests from rest of tests in the Query Service GUI CI.Apr 16 2019, 10:41 AM
noarave mentioned this in rWDQGb629ee752c80: Separate browser tests from rest of tests in the Query Service GUI CI.Apr 16 2019, 10:51 AM
noarave added a comment.EditedApr 17 2019, 8:01 AM

To avoid wikidata-query-rdf build CI running query-gui browser tests we have moved the wdio tests into a separate task: grunt browser_test.
This will be called in npm deploywhich in its turn gets run as part of wikidata-query-gui-build. This resolves the issue discussed in this task.

However, it seems that wikidata-query-gui-build only runs on wikidata-query-gui postmerge. Since this is what runs the tests it makes sense for it to run as a test job (i.e. on gerrit after adding a new patch). This probably justifies a separate task and requires release engineering input. tagging @zeljkofilipin can you maybe help?

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 17 2019, 8:10 AM
noarave added a subscriber: zeljkofilipin.Apr 17 2019, 8:16 AM
gerritbot added a comment.Apr 17 2019, 3:59 PM

Change 504287 merged by jenkins-bot:
[wikidata/query/gui@master] Separate browser tests from rest of tests in the Query Service GUI CI

https://gerrit.wikimedia.org/r/504287

Smalyshev added a comment.Apr 17 2019, 8:51 PM

Still getting failures, see: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker/855/console

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 18 2019, 9:08 AM
gerritbot added a comment.Apr 26 2019, 1:31 PM

Change 506666 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[wikidata/query/gui@master] Remove wdio tests from gui query servive grunt test task

https://gerrit.wikimedia.org/r/506666

noarave mentioned this in rWDQG528d333273c1: Remove wdio tests from gui query servive grunt test task.Apr 26 2019, 1:33 PM
gerritbot added a comment.Apr 26 2019, 1:35 PM

Change 506666 merged by jenkins-bot:
[wikidata/query/gui@master] Remove wdio tests from gui query servive grunt test task

https://gerrit.wikimedia.org/r/506666

gerritbot added a comment.Apr 26 2019, 1:38 PM

Change 506667 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 528d333273c19da91105d7a17e6c248bc6803ca1:

https://gerrit.wikimedia.org/r/506667

gerritbot added a comment.Apr 26 2019, 1:40 PM

Change 506668 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[wikidata/query/rdf@master] Updated gui submodule

https://gerrit.wikimedia.org/r/506668

gerritbot added a comment.Apr 26 2019, 5:01 PM

Change 506667 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 528d333273c19da91105d7a17e6c248bc6803ca1:

https://gerrit.wikimedia.org/r/506667

Smalyshev closed this task as Resolved.Apr 26 2019, 6:23 PM

Looks like it's not broken anymore. Thanks!

WMDE-leszek mentioned this in T222200: Run browser tests as part of "npm test" for wikidata/query/gui in CI.Apr 30 2019, 4:21 PM
noarave mentioned this in rWDQG27652e6453cc: Rename separate grunt task from 'browser_test' to 'test_all'.May 19 2019, 12:30 PM
noarave mentioned this in rWDQGb5558fd4cd2a: Rename separate grunt task from 'browser_test' to 'test_all'.May 27 2019, 8:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL