Page MenuHomePhabricator

[Extension:SearchStats] quibble tests failing due to deprecated OutputPage::addWikiText
Closed, ResolvedPublic

Description

Per OutputPage comment doc:

@deprecated since 1.32 due to untidy output; use
        addWikiTextAsInterface() if $interface is default value or true,
        or else addWikiTextAsContent() if $interface is false.

(Line 35 in SpecialSearchStats.php)

Issue found in unrelated i18n patch, see also: T216869

Event Timeline

sbassett created this task.Apr 5 2019, 4:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2019, 4:38 PM
sbassett triaged this task as Low priority.Apr 5 2019, 4:38 PM
sbassett updated the task description. (Show Details)Apr 5 2019, 4:41 PM

Patch for review. Feel free to abandon if we want to leave this as an exercise for new mw developers.

Change 501633 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/SearchStats@master] Extension: SearchStats

https://gerrit.wikimedia.org/r/501633

Change 501959 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SearchStats@master] Avoid deprecated OutputPage::addWikiText

https://gerrit.wikimedia.org/r/501959

Change 501633 abandoned by SBassett:
Extension: SearchStats

Reason:
^

https://gerrit.wikimedia.org/r/501633

Change 501959 merged by jenkins-bot:
[mediawiki/extensions/SearchStats@master] Avoid deprecated OutputPage::addWikiText

https://gerrit.wikimedia.org/r/501959

Umherirrender closed this task as Resolved.Aug 4 2019, 6:17 PM
Umherirrender claimed this task.