Maniphest T220220

[Extension:SearchStats] quibble tests failing due to deprecated OutputPage::addWikiText
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	sbassett
	Apr 5 2019, 4:38 PM

Description

Per OutputPage comment doc:

@deprecated since 1.32 due to untidy output; use
        addWikiTextAsInterface() if $interface is default value or true,
        or else addWikiTextAsContent() if $interface is false.

(Line 35 in SpecialSearchStats.php)

Issue found in unrelated i18n patch, see also: T216869

Details

	Subject	Repo	Branch	Lines +/-
	Avoid deprecated OutputPage::addWikiText	mediawiki/extensions/SearchStats	master	+24 -19
	Extension: SearchStats	mediawiki/extensions/SearchStats	master	+20 -20

Customize query in gerrit

Related Objects

Mentioned In: rESSe554d49db644: Avoid deprecated OutputPage::addWikiText
rESS1f4cfe1785ba: Avoid deprecated OutputPage::addWikiText
rESS29fb5ba4e5f6: Avoid deprecated OutputPage::addWikiText
rESSd5b59cd6277f: Extension: SearchStats
rESS55f624dd8a8d: Extension: SearchStats
Mentioned Here: T216869: [Extension:SearchStats] The i18n key searchstats is missing

Event Timeline

sbassett created this task.Apr 5 2019, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2019, 4:38 PM

sbassett triaged this task as Low priority.Apr 5 2019, 4:38 PM

sbassett updated the task description. (Show Details)Apr 5 2019, 4:41 PM

sbassett added a project: Patch-For-Review.Apr 5 2019, 4:46 PM

Patch for review. Feel free to abandon if we want to leave this as an exercise for new mw developers.

sbassett mentioned this in rESS55f624dd8a8d: Extension: SearchStats.Apr 5 2019, 4:51 PM

Change 501633 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/SearchStats@master] Extension: SearchStats

https://gerrit.wikimedia.org/r/501633

sbassett mentioned this in rESSd5b59cd6277f: Extension: SearchStats.Apr 5 2019, 5:03 PM

Change 501959 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SearchStats@master] Avoid deprecated OutputPage::addWikiText

https://gerrit.wikimedia.org/r/501959

Umherirrender mentioned this in rESS29fb5ba4e5f6: Avoid deprecated OutputPage::addWikiText.Apr 6 2019, 7:48 PM

Change 501633 abandoned by SBassett:
Extension: SearchStats

Reason:
^

https://gerrit.wikimedia.org/r/501633

Umherirrender mentioned this in rESS1f4cfe1785ba: Avoid deprecated OutputPage::addWikiText.Apr 8 2019, 6:27 PM

sbassett mentioned this in rESSe554d49db644: Avoid deprecated OutputPage::addWikiText.Apr 8 2019, 6:58 PM

Change 501959 merged by jenkins-bot:
[mediawiki/extensions/SearchStats@master] Avoid deprecated OutputPage::addWikiText

https://gerrit.wikimedia.org/r/501959

Umherirrender closed this task as Resolved.Aug 4 2019, 6:17 PM

Umherirrender claimed this task.

Peachey88 edited projects, added MediaWiki-extensions-SearchStats; removed MediaWiki-extensions-Other.Mar 28 2020, 5:30 AM