Page MenuHomePhabricator

Languages box should rely on dynamic column sizing, not fixed
Closed, ResolvedPublic

Assigned To
Authored By
Volker_E
Apr 12 2019, 9:51 PM
Referenced Files
F29226633: image.png
May 23 2019, 9:39 PM
F28632086: image.png
Apr 12 2019, 9:51 PM
F28632068: image.png
Apr 12 2019, 9:51 PM
F28631882: image.png
Apr 12 2019, 9:51 PM
F28631863: image.png
Apr 12 2019, 9:51 PM

Description

Translate's languages box relies on fixed column width currently, width: 15% for the first with the (in English) “Other languages:” label, width: 80% for the second one with the languages.

Current (Vector)Current (Vector, widescreen)
image.png (273×1 px, 120 KB)
image.png (242×2 px, 119 KB)

Proposal

  • Limiting the first column width to label only (guess, that the percentage widths have been added to please older browsers, seems obsolete now).
  • Removing separating border between label and languages, they are visually separated by background colors anyways. The colon is implying following information. Removing reduces visual noise.
Proposed (Vector)(Vector, widescreen)
image.png (312×921 px, 125 KB)
image.png (220×2 px, 114 KB)

Event Timeline

Change 503420 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Translate@master] Reduce visual noice in language list box

https://gerrit.wikimedia.org/r/503420

Change 503420 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Reduce visual noise in language list box

https://gerrit.wikimedia.org/r/503420

Nikerabbit assigned this task to Volker_E.
Nikerabbit triaged this task as Low priority.
Nikerabbit removed a project: Patch-For-Review.
Quiddity added a subscriber: Quiddity.

This change seems to have created a problem, if the list of existing translations is short.
E.g. at https://meta.wikimedia.org/wiki/User:Quiddity_(WMF)/CX_outreach
and at https://www.mediawiki.org/wiki/Manual:RecountCategories.php
the table gives too much space to the Other languages: cell:

image.png (499×1 px, 109 KB)

Reproduced in Firefox and Chromium on Mint Linux, logged-in/out.

This comment was removed by Volker_E.

Change 512462 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Translate@master] Make first column's width in language list box always adapt to content

https://gerrit.wikimedia.org/r/512462

Change 512462 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Make first column's width in language list box always adapt to content

https://gerrit.wikimedia.org/r/512462