Actively delete echo_event rows when they become orphaned
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Apr 17 2019, 4:40 PM

Description

Instead of periodically purging orphaned echo_event rows using removeOrphanedEvents.php, we should actively delete them when the last thing that refers to them is deleted. This means that when an echo_notification row is deleted (because the user exceeded the 2000 notification limit) and when an echo_email_batch row is deleted (because the email was sent), we should check whether the echo_event rows they refer to still have other things referring to them, and if not, delete them.

When deleting these echo_event rows, we also need to delete the corresponding echo_target_page rows, per T221261.

Details

	Subject	Repo	Branch	Lines +/-
	Proactively delete echo_event rows when they become orphaned	mediawiki/extensions/Echo	REL1_33	+145 -23
	Proactively delete echo_event rows when they become orphaned	mediawiki/extensions/Echo	master	+145 -23

Customize query in gerrit

Related Objects

Mentioned In: T318523: Don't send article-linked notifications for bots
T308084: Reduce DB space used by Echo notifications
W2269 Echo Tasks
T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them
Mentioned Here: T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them

Event Timeline

Catrope created this task.Apr 17 2019, 4:40 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 17 2019, 4:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Catrope mentioned this in T221261: When deleting orphaned echo_event rows, also delete echo_target_page rows that refer to them.Apr 17 2019, 4:40 PM

SBisson mentioned this in W2269 Echo Tasks.Apr 17 2019, 4:51 PM

Change 505829 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] Proactively delete echo_event rows when they become orphaned

https://gerrit.wikimedia.org/r/505829

gerritbot added a project: Patch-For-Review.Apr 23 2019, 5:19 PM

Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Apr 23 2019, 5:20 PM

Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Catrope claimed this task.Apr 24 2019, 4:04 PM

SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 2 2019, 7:30 PM

Change 505829 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Proactively delete echo_event rows when they become orphaned

https://gerrit.wikimedia.org/r/505829

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 2 2019, 8:00 PM

Checked in betalabs

@deployment-deploy01:~$ mwscript extensions/Echo/maintenance/removeOrphanedEvents.php --wiki=enwiki --force
Removing orphaned echo_event rows...

MariaDB [enwiki]> SELECT COUNT(*) FROM echo_event LEFT JOIN echo_notification ON notification_event=event_id WHERE notification_timestamp IS NULL;
+----------+
| COUNT(*) |
+----------+
|        0 |
+----------+
1 row in set (0.15 sec)

Change 532483 had a related patch set uploaded (by Paladox; owner: Catrope):
[mediawiki/extensions/Echo@REL1_33] Proactively delete echo_event rows when they become orphaned

https://gerrit.wikimedia.org/r/532483

Change 532483 merged by jenkins-bot:
[mediawiki/extensions/Echo@REL1_33] Proactively delete echo_event rows when they become orphaned

https://gerrit.wikimedia.org/r/532483

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 9:11 PM

Catrope mentioned this in T308084: Reduce DB space used by Echo notifications.May 12 2022, 5:31 PM

Etonkovidova mentioned this in T318523: Don't send article-linked notifications for bots.Aug 8 2023, 2:18 AM