Page MenuHomePhabricator

Depicts panel heading/url/button text alignment is off
Closed, ResolvedPublic

Description

This is a small, but persistent detail that hasn't been resolved yet and is now on production.

We have this, where the heading, the url, and the button text are not aligned by the baseline of the text:

FP alignment.png (656×3 px, 117 KB)

close-up:

Screenshot 2019-04-29 16.41.06.png (210×2 px, 28 KB)

We want this:
"Items portrayed in this file", Q number url, and Edit button are aligned at the text baseline. Which ever text element is easiest to align to would be fine (perhaps Edit?).

Acceptance Criteria:

  • All text along this row (heading/url/button text) are aligned at the base of the text.

Event Timeline

Change 509368 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Convert edit button to a plain link

https://gerrit.wikimedia.org/r/509368

Change 509367 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Mobile fixes

https://gerrit.wikimedia.org/r/509367

Change 509368 abandoned by Matthias Mullie:
Fix alignment of edit with title & link on same line

Reason:
Ended up including this in another patch

https://gerrit.wikimedia.org/r/509368

Change 509367 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Mobile fixes

https://gerrit.wikimedia.org/r/509367

Checked on production and alignment is good.