Code search tells me there are uses of something like `using( 'schema.*' ) in:
- modules/all/ext.wikimediaEvents.searchSatisfaction.js#550
- modules/all/ext.wikimediaEvents.searchSatisfaction.js#879
I'm going to change this to just not use the modules.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove mentions of schema.* ResourceLoader modules | mediawiki/extensions/WikimediaEvents | master | +3 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T219342 Pageview performance timeline analysis (March 2019) | |||
| Resolved | Milimetric | T221281 Remove deprecated EventLogging schema modules | |||
| Resolved | Milimetric | T223285 Remove deprecated using schema.* syntax from WikimediaEvents |
Event Timeline
Comment Actions
@Milimetric Remember that while mw.track is encouraged overall (async, dependency-free, allows soft integration with EL), the mw.eventLog interface is not deprecated or discouraged in any way and can sometimes be preferred in specific use cases, especially for existing code that (for better or worse) is written to work with that kind of interface. Also if the code has tightly coupled unit tests, that might safe you a lot of work.
If you want a simpler, lower-risk, change instead, you could only swap schema.* for ext.eventLogging and keep the rest as-is. If it already specifies ext.eventLogging in the array, removing schema.* is trivial. If it only specifies, schema.*, specify ext.eventLogging instead.
It could then be an (optional) migration task for later consideration by the maintainers to adopt mw.track if the relative benefits apply to them.
Hope that helps!
Comment Actions
Change 510284 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[mediawiki/extensions/WikimediaEvents@master] Remove mentions of schema.* ResourceLoader modules
Comment Actions
Change 510284 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Remove mentions of schema.* ResourceLoader modules